You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/24 21:55:18 UTC
[GitHub] [arrow-rs] mzeitlin11 opened a new pull request #601: Implement `StringBuilder::append_option`
mzeitlin11 opened a new pull request #601:
URL: https://github.com/apache/arrow-rs/pull/601
# Which issue does this PR close?
Closes #263.
# Are there any user-facing changes?
Addition of a new method, `StringBuilder::append_option` (please let me know if this should be added to the CHANGELOG)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #601: Implement `StringBuilder::append_option`
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #601:
URL: https://github.com/apache/arrow-rs/pull/601#discussion_r676131867
##########
File path: arrow/src/array/builder.rs
##########
@@ -2991,6 +3001,23 @@ mod tests {
assert_eq!(5, string_array.value_length(2));
}
+ #[test]
+ fn test_string_array_builder_append_option() {
+ let mut builder = StringBuilder::new(20);
+ builder.append_option(Some("hello")).unwrap();
+ builder.append_option(None::<&str>).unwrap();
+ builder.append_option(None::<String>).unwrap();
Review comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #601: Implement `StringBuilder::append_option`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #601:
URL: https://github.com/apache/arrow-rs/pull/601#issuecomment-886190392
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#601](https://codecov.io/gh/apache/arrow-rs/pull/601?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e370163) into [master](https://codecov.io/gh/apache/arrow-rs/commit/87d284000c49d3607a1ec4e0cf5e0bf7fe9d552a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87d2840) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #601 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 167 167
Lines 46232 46249 +17
=======================================
+ Hits 38100 38118 +18
+ Misses 8132 8131 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIucnM=) | `86.26% <100.00%> (+0.15%)` | :arrow_up: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `95.04% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/601?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/601?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [87d2840...e370163](https://codecov.io/gh/apache/arrow-rs/pull/601?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #601: Implement `StringBuilder::append_option`
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #601:
URL: https://github.com/apache/arrow-rs/pull/601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org