You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hust-hhb (via GitHub)" <gi...@apache.org> on 2025/05/08 04:05:50 UTC
[PR] [improve](group commit)Print file size when relaying wal [doris]
hust-hhb opened a new pull request, #50688:
URL: https://github.com/apache/doris/pull/50688
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on code in PR #50688:
URL: https://github.com/apache/doris/pull/50688#discussion_r2078849634
##########
be/src/olap/wal/wal_table.cpp:
##########
@@ -89,12 +89,17 @@ Status WalTable::_relay_wal_one_by_one() {
wal_info->add_retry_num();
auto st = _replay_wal_internal(wal_info->get_wal_path());
auto msg = st.msg();
+ std::filesystem::path file_path(wal_info->get_wal_path());
+ if (!std::filesystem::exists(file_path)) {
+ LOG(WARNING) << "wal file=" << wal_info->get_wal_path() << " does not exist";
+ }
+ auto file_size = std::filesystem::file_size(file_path);
Review Comment:
if the file does not exist, file_size maybe throw a exception, and we should catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2861730375
<details>
<summary>ClickBench: <b>Total hot run time: 28.86 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5f6a14dca4925cc2ca61198a04c0da05e8fd6249, data reload: false
query1 0.03 0.03 0.02
query2 0.12 0.11 0.11
query3 0.26 0.19 0.19
query4 1.60 0.20 0.19
query5 0.59 0.57 0.58
query6 1.18 0.70 0.71
query7 0.03 0.02 0.01
query8 0.04 0.03 0.04
query9 0.58 0.51 0.51
query10 0.57 0.58 0.56
query11 0.16 0.10 0.11
query12 0.15 0.11 0.11
query13 0.62 0.60 0.60
query14 0.79 0.80 0.83
query15 0.87 0.85 0.88
query16 0.38 0.38 0.39
query17 1.02 1.07 1.03
query18 0.21 0.19 0.19
query19 1.88 1.80 1.82
query20 0.01 0.01 0.01
query21 15.41 0.92 0.56
query22 0.77 1.14 0.75
query23 14.84 1.40 0.61
query24 7.68 1.38 0.35
query25 0.30 0.09 0.08
query26 0.62 0.17 0.14
query27 0.05 0.05 0.05
query28 8.62 0.89 0.44
query29 12.54 3.93 3.25
query30 0.25 0.09 0.07
query31 2.83 0.59 0.39
query32 3.23 0.55 0.47
query33 3.02 3.18 3.12
query34 15.76 5.13 4.48
query35 4.54 4.52 4.54
query36 0.67 0.50 0.51
query37 0.08 0.06 0.06
query38 0.06 0.04 0.04
query39 0.03 0.02 0.02
query40 0.17 0.15 0.13
query41 0.08 0.02 0.03
query42 0.03 0.02 0.02
query43 0.03 0.04 0.03
Total cold run time: 102.7 s
Total hot run time: 28.86 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2862697806
# BE Regression && UT Coverage Report
Increment line coverage `0.00% (0/10)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50688_9f65ce2fd6dcf34e8f1ecc094c57ce057c2589bb_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50688_9f65ce2fd6dcf34e8f1ecc094c57ce057c2589bb_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.15% (20776/26250) |
| Line Coverage | 72.41% (213428/294745) |
| Region Coverage | 70.65% (126373/178884) |
| Branch Coverage | 64.26% (65104/101314) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2862245372
<details>
<summary>TPC-DS: <b>Total hot run time: 192636 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9f65ce2fd6dcf34e8f1ecc094c57ce057c2589bb, data reload: false
query1 1398 1126 1045 1045
query2 6237 1849 1808 1808
query3 11056 4446 4511 4446
query4 53352 25188 23197 23197
query5 5215 557 475 475
query6 352 210 197 197
query7 4866 524 297 297
query8 329 274 243 243
query9 5456 2567 2557 2557
query10 430 329 266 266
query11 15040 15023 14857 14857
query12 158 115 107 107
query13 1039 552 389 389
query14 10308 6624 6514 6514
query15 208 192 185 185
query16 7077 691 461 461
query17 1096 768 601 601
query18 1579 420 340 340
query19 216 202 219 202
query20 138 130 121 121
query21 206 123 108 108
query22 4380 4387 4201 4201
query23 34398 33452 33478 33452
query24 6578 2417 2492 2417
query25 486 493 415 415
query26 702 277 159 159
query27 2422 506 343 343
query28 2922 2147 2124 2124
query29 586 571 446 446
query30 273 227 191 191
query31 859 848 786 786
query32 77 65 60 60
query33 465 357 318 318
query34 876 889 527 527
query35 841 850 746 746
query36 959 996 902 902
query37 120 100 81 81
query38 4263 4403 4262 4262
query39 1518 1417 1444 1417
query40 213 121 109 109
query41 59 54 55 54
query42 123 110 106 106
query43 510 511 490 490
query44 1386 836 841 836
query45 188 176 167 167
query46 865 1031 661 661
query47 1865 1883 1772 1772
query48 379 425 309 309
query49 694 547 434 434
query50 689 721 410 410
query51 4226 4225 4105 4105
query52 116 108 102 102
query53 237 283 203 203
query54 615 593 517 517
query55 90 86 96 86
query56 330 317 310 310
query57 1155 1210 1141 1141
query58 277 261 271 261
query59 2693 2857 2761 2761
query60 343 357 306 306
query61 130 155 128 128
query62 755 734 664 664
query63 224 200 186 186
query64 1840 1055 728 728
query65 4319 4228 4282 4228
query66 763 414 314 314
query67 15983 15706 15392 15392
query68 7503 900 514 514
query69 536 303 259 259
query70 1235 1128 1058 1058
query71 512 333 302 302
query72 5993 4856 4987 4856
query73 1469 677 342 342
query74 8999 9169 8759 8759
query75 3835 3239 2705 2705
query76 4228 1192 749 749
query77 638 355 281 281
query78 10001 10027 9270 9270
query79 6625 789 540 540
query80 690 524 454 454
query81 486 259 219 219
query82 718 136 97 97
query83 343 250 241 241
query84 291 107 106 106
query85 821 355 315 315
query86 354 280 281 280
query87 4379 4430 4392 4392
query88 3463 2236 2189 2189
query89 453 312 275 275
query90 1952 201 206 201
query91 141 141 113 113
query92 73 63 53 53
query93 3540 934 565 565
query94 696 414 303 303
query95 379 307 285 285
query96 485 554 269 269
query97 3142 3200 3149 3149
query98 231 206 200 200
query99 1457 1401 1252 1252
Total cold run time: 305216 ms
Total hot run time: 192636 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2861684902
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2861684990
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2862551165
# BE UT Coverage Report
Increment line coverage `0.00% (0/10)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/9f65ce2fd6dcf34e8f1ecc094c57ce057c2589bb_9f65ce2fd6dcf34e8f1ecc094c57ce057c2589bb/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/9f65ce2fd6dcf34e8f1ecc094c57ce057c2589bb_9f65ce2fd6dcf34e8f1ecc094c57ce057c2589bb/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.67% (14892/26751) |
| Line Coverage | 44.49% (131346/295242) |
| Region Coverage | 43.40% (66187/152522) |
| Branch Coverage | 38.07% (33800/88782) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2863016305
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on code in PR #50688:
URL: https://github.com/apache/doris/pull/50688#discussion_r2079105668
##########
be/src/olap/wal/wal_table.cpp:
##########
@@ -89,12 +89,17 @@ Status WalTable::_relay_wal_one_by_one() {
wal_info->add_retry_num();
auto st = _replay_wal_internal(wal_info->get_wal_path());
auto msg = st.msg();
+ std::filesystem::path file_path(wal_info->get_wal_path());
+ if (!std::filesystem::exists(file_path)) {
+ LOG(WARNING) << "wal file=" << wal_info->get_wal_path() << " does not exist";
+ }
+ auto file_size = std::filesystem::file_size(file_path);
Review Comment:
@dataroaring already change the code, check file exist before getting file size and replaying wal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2862099809
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2861724317
<details>
<summary>TPC-DS: <b>Total hot run time: 185347 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5f6a14dca4925cc2ca61198a04c0da05e8fd6249, data reload: false
query1 1004 485 530 485
query2 6565 1759 1764 1759
query3 6742 229 221 221
query4 26162 23554 23142 23142
query5 4402 653 473 473
query6 301 210 195 195
query7 4618 485 276 276
query8 290 262 228 228
query9 8612 2553 2565 2553
query10 488 323 271 271
query11 15628 15087 14882 14882
query12 172 109 112 109
query13 1662 532 407 407
query14 9739 6151 6027 6027
query15 209 197 171 171
query16 7430 647 481 481
query17 1169 731 602 602
query18 1982 398 305 305
query19 220 181 158 158
query20 125 117 121 117
query21 207 149 109 109
query22 4025 4153 3963 3963
query23 34028 33011 32952 32952
query24 8467 2432 2395 2395
query25 541 456 383 383
query26 1220 273 157 157
query27 2750 493 340 340
query28 4365 2069 2047 2047
query29 709 548 421 421
query30 289 219 189 189
query31 962 876 733 733
query32 78 65 64 64
query33 550 377 313 313
query34 803 862 511 511
query35 781 802 743 743
query36 958 996 874 874
query37 114 101 80 80
query38 4168 4164 4072 4072
query39 1438 1404 1396 1396
query40 216 121 105 105
query41 88 55 57 55
query42 121 116 108 108
query43 492 508 473 473
query44 1330 806 798 798
query45 176 173 172 172
query46 840 1021 648 648
query47 1757 1796 1728 1728
query48 374 433 301 301
query49 786 506 430 430
query50 648 691 413 413
query51 4092 4215 4071 4071
query52 113 108 101 101
query53 222 271 187 187
query54 581 582 497 497
query55 86 80 79 79
query56 311 302 318 302
query57 1162 1154 1072 1072
query58 256 259 255 255
query59 2397 2535 2388 2388
query60 337 328 320 320
query61 130 128 150 128
query62 795 743 661 661
query63 227 189 189 189
query64 4371 1131 786 786
query65 4333 4246 4225 4225
query66 1145 439 346 346
query67 15651 15740 15329 15329
query68 7788 904 523 523
query69 472 327 281 281
query70 1194 1126 1122 1122
query71 446 319 308 308
query72 5941 4676 4754 4676
query73 681 631 350 350
query74 8920 9089 8754 8754
query75 3470 3213 2700 2700
query76 3276 1199 769 769
query77 571 496 290 290
query78 9963 10194 9266 9266
query79 2290 815 553 553
query80 609 511 446 446
query81 503 259 230 230
query82 457 127 109 109
query83 251 251 230 230
query84 244 109 83 83
query85 791 411 311 311
query86 379 304 296 296
query87 4438 4404 4316 4316
query88 3628 2247 2242 2242
query89 390 318 281 281
query90 1947 211 213 211
query91 144 143 113 113
query92 82 62 61 61
query93 1822 947 577 577
query94 709 415 310 310
query95 373 315 287 287
query96 484 557 270 270
query97 3173 3194 3120 3120
query98 223 222 214 214
query99 1499 1413 1277 1277
Total cold run time: 274168 ms
Total hot run time: 185347 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2862123169
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2862211894
<details>
<summary>TPC-H: <b>Total hot run time: 33744 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9f65ce2fd6dcf34e8f1ecc094c57ce057c2589bb, data reload: false
------ Round 1 ----------------------------------
q1 26750 5031 5032 5031
q2 2100 289 179 179
q3 10403 1261 698 698
q4 10223 972 527 527
q5 7527 2259 2371 2259
q6 177 170 139 139
q7 903 757 615 615
q8 9319 1261 1061 1061
q9 6768 4984 5073 4984
q10 6855 2296 1881 1881
q11 489 282 285 282
q12 346 353 227 227
q13 17768 3677 3117 3117
q14 234 236 210 210
q15 525 479 470 470
q16 447 436 391 391
q17 576 856 364 364
q18 7472 7120 7107 7107
q19 1845 977 544 544
q20 346 351 219 219
q21 3867 3438 2475 2475
q22 1031 1015 964 964
Total cold run time: 115971 ms
Total hot run time: 33744 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5153 5039 5026 5026
q2 229 317 228 228
q3 2202 2679 2279 2279
q4 1325 1767 1368 1368
q5 4467 4359 4404 4359
q6 220 168 125 125
q7 2022 2054 1761 1761
q8 2602 2690 2624 2624
q9 7250 7128 7015 7015
q10 3014 3211 2750 2750
q11 564 521 490 490
q12 686 812 634 634
q13 3550 3915 3318 3318
q14 301 309 263 263
q15 509 478 468 468
q16 439 478 463 463
q17 1149 1495 1415 1415
q18 7727 7549 7388 7388
q19 805 777 857 777
q20 1968 1967 1849 1849
q21 5069 4959 4637 4637
q22 1116 1079 1015 1015
Total cold run time: 52367 ms
Total hot run time: 50252 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2861708829
<details>
<summary>TPC-H: <b>Total hot run time: 34025 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5f6a14dca4925cc2ca61198a04c0da05e8fd6249, data reload: false
------ Round 1 ----------------------------------
q1 26480 5047 5066 5047
q2 2070 281 187 187
q3 10392 1259 713 713
q4 10246 1008 532 532
q5 7509 2449 2348 2348
q6 185 170 138 138
q7 916 766 641 641
q8 9324 1456 1069 1069
q9 6820 5085 5134 5085
q10 6836 2333 1900 1900
q11 492 277 261 261
q12 347 352 216 216
q13 17757 3694 3100 3100
q14 233 238 209 209
q15 553 499 516 499
q16 434 446 375 375
q17 591 868 357 357
q18 7634 7204 7082 7082
q19 1212 937 583 583
q20 334 335 226 226
q21 4151 3397 2475 2475
q22 1039 1018 982 982
Total cold run time: 115555 ms
Total hot run time: 34025 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5142 5088 5123 5088
q2 240 325 227 227
q3 2155 2644 2270 2270
q4 1311 1778 1335 1335
q5 4657 4489 4379 4379
q6 216 172 130 130
q7 1954 1931 1715 1715
q8 2582 2495 2454 2454
q9 7268 7175 7202 7175
q10 3064 3177 2768 2768
q11 565 508 476 476
q12 699 748 626 626
q13 3551 3900 3240 3240
q14 273 287 276 276
q15 533 496 498 496
q16 444 489 425 425
q17 1159 1570 1374 1374
q18 7576 7539 7430 7430
q19 863 950 1160 950
q20 1976 2019 1927 1927
q21 5249 4633 4485 4485
q22 1069 1010 942 942
Total cold run time: 52546 ms
Total hot run time: 50188 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2862259124
<details>
<summary>ClickBench: <b>Total hot run time: 28.84 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9f65ce2fd6dcf34e8f1ecc094c57ce057c2589bb, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.12
query3 0.25 0.19 0.20
query4 1.60 0.20 0.11
query5 0.57 0.55 0.56
query6 1.20 0.71 0.72
query7 0.02 0.02 0.01
query8 0.04 0.04 0.04
query9 0.57 0.52 0.51
query10 0.59 0.57 0.57
query11 0.15 0.11 0.11
query12 0.14 0.11 0.11
query13 0.61 0.59 0.59
query14 0.78 0.81 0.79
query15 0.87 0.84 0.86
query16 0.38 0.38 0.39
query17 1.04 1.00 1.02
query18 0.22 0.20 0.20
query19 1.90 1.76 1.83
query20 0.01 0.02 0.01
query21 15.40 0.86 0.53
query22 0.75 1.34 0.73
query23 14.75 1.39 0.57
query24 7.60 1.08 0.74
query25 0.51 0.18 0.07
query26 0.56 0.17 0.15
query27 0.05 0.05 0.04
query28 9.28 0.84 0.43
query29 12.55 3.91 3.23
query30 0.27 0.10 0.07
query31 2.82 0.59 0.38
query32 3.22 0.55 0.46
query33 3.02 3.07 3.01
query34 15.73 5.04 4.51
query35 4.49 4.52 4.51
query36 0.66 0.49 0.48
query37 0.09 0.06 0.06
query38 0.04 0.04 0.03
query39 0.03 0.02 0.03
query40 0.16 0.14 0.13
query41 0.08 0.03 0.03
query42 0.03 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 103.22 s
Total hot run time: 28.84 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit)Print file size when relaying wal [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50688:
URL: https://github.com/apache/doris/pull/50688#issuecomment-2861835329
# BE UT Coverage Report
Increment line coverage `0.00% (0/6)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5f6a14dca4925cc2ca61198a04c0da05e8fd6249_5f6a14dca4925cc2ca61198a04c0da05e8fd6249/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5f6a14dca4925cc2ca61198a04c0da05e8fd6249_5f6a14dca4925cc2ca61198a04c0da05e8fd6249/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.60% (14871/26747) |
| Line Coverage | 44.46% (131268/295267) |
| Region Coverage | 43.35% (66088/152455) |
| Branch Coverage | 38.04% (33761/88754) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org