You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/22 17:03:43 UTC

[GitHub] [tinkerpop] divijvaidya commented on pull request #1730: Adds status_message as a property on GremlinServerError

divijvaidya commented on PR #1730:
URL: https://github.com/apache/tinkerpop/pull/1730#issuecomment-1163389110

   Thank you for submitting your first patch to TinkerPop 🥳. Looks like a reasonable change to me. 
   
   Couple of comments:
   1. Can you please associate this change with a JIRA? You can find the information here: https://tinkerpop.apache.org/docs/current/dev/developer/#_contributing_code_changes 
   2. Please add test coverage for this change. Perhaps a good place would be here: https://github.com/apache/tinkerpop/blob/master/gremlin-python/src/main/python/tests/driver/test_client.py#L78
   3. Please add an entry in `CHANGELOG.asciidoc` as mentioned in the link in point 1 above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org