[jira] [Commented] (LUCENE-6801) PhraseQuery incorrectly advertises it supports terms at the same position

["Adrien Grand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963028#comment-14963028 ] 

Adrien Grand commented on LUCENE-6801:
--------------------------------------

+1 overall. I'm just bit worried about the following comment you added to {{getPositions()}}:

{noformat}
It's a copy of the underlying data.
{noformat}

It might sound like it's ok to modify it since it will not mutate internal data of the phrase query?

> PhraseQuery incorrectly advertises it supports terms at the same position
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-6801
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6801
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/search
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: LUCENE_6801.patch
>
>
> The following in PhraseQuery has been here since Sept 15th 2004 (by "goller"):
> {code:java}
>     /**
>      * Adds a term to the end of the query phrase.
>      * The relative position of the term within the phrase is specified explicitly.
>      * This allows e.g. phrases with more than one term at the same position
>      * or phrases with gaps (e.g. in connection with stopwords).
>      * 
>      */
>     public Builder add(Term term, int position) {
> {code}
> Of course this isn't true; it's why we have MultiPhraseQuery.  Yet we even allow you to have consecutive terms with the same positions.  We shouldn't allow that; we should throw an exception.  For my own sanity, I modified a simple MultiPhraseQuery test to use PhraseQuery instead and of course it didn't work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org