You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2016/12/05 09:46:13 UTC
svn commit: r1772615 - in /tomcat/trunk:
java/org/apache/coyote/http11/filters/ChunkedInputFilter.java
res/findbugs/filter-false-positives.xml
Author: markt
Date: Mon Dec 5 09:46:13 2016
New Revision: 1772615
URL: http://svn.apache.org/viewvc?rev=1772615&view=rev
Log:
Review current FindBugs failures (all false positives)
Modified:
tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java?rev=1772615&r1=1772614&r2=1772615&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java Mon Dec 5 09:46:13 2016
@@ -446,6 +446,7 @@ public class ChunkedInputFilter implemen
}
}
+ // readBytes() above will set readChunk unless it returns a value < 0
chr = readChunk.get(readChunk.position());
// CRLF terminates the request
@@ -472,6 +473,7 @@ public class ChunkedInputFilter implemen
}
}
+ // readBytes() above will set readChunk unless it returns a value < 0
chr = readChunk.get(readChunk.position());
if ((chr >= Constants.A) && (chr <= Constants.Z)) {
chr = (byte) (chr - Constants.LC_OFFSET);
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1772615&r1=1772614&r2=1772615&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Mon Dec 5 09:46:13 2016
@@ -424,6 +424,12 @@
<Bug pattern="AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION" />
</Match>
<Match>
+ <!-- readChunk will not be null due to previous call to readBytes() -->
+ <Class name="org.apache.coyote.http11.filters.ChunkedInputFilter" />
+ <Method name="parseHeader"/>
+ <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE" />
+ </Match>
+ <Match>
<!-- Locks are always released. Non-standard pattern is required because -->
<!-- of lock upgrade that is used. -->
<Class name="org.apache.coyote.http11.upgrade.AprServletInputStream" />
@@ -458,6 +464,12 @@
<Bug code="UL" />
</Match>
<Match>
+ <!-- HpackDecoder is used by multiple streams but not concurrently. -->
+ <Class name="org.apache.coyote.http2.HpackDecoder" />
+ <Method name="emitHeader" />
+ <Bug pattern="VO_VOLATILE_INCREMENT" />
+ </Match>
+ <Match>
<!-- Number being tested is unsigned. -->
<Class name="org.apache.coyote.http2.Http2UpgradeHandler" />
<Method name="createRemoteStream" />
@@ -937,6 +949,18 @@
<Bug code="UG" />
</Match>
<Match>
+ <!-- Return value of latch is intentionally ignored -->
+ <Class name="org.apache.catalina.connector.TestSendFile"/>
+ <Method name="testBug60409"/>
+ <Bug pattern="RV_RETURN_VALUE_IGNORED"/>
+ </Match>
+ <Match>
+ <!-- Return value of latch is intentionally ignored -->
+ <Class name="org.apache.catalina.nonblocking.TestNonBlockingAPI"/>
+ <Method name="testDelayedNBWrite"/>
+ <Bug pattern="RV_RETURN_VALUE_IGNORED"/>
+ </Match>
+ <Match>
<Or>
<Class name="org.apache.catalina.startup.TestListener$SCL" />
<Class name="org.apache.catalina.startup.TestListener$SCL3" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org