You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/07/14 10:17:29 UTC
[GitHub] [kylin] codecov-io commented on issue #689: KYLIN-4047 Use
push-down query when division dynamic column cube query is not supported
codecov-io commented on issue #689: KYLIN-4047 Use push-down query when division dynamic column cube query is not supported
URL: https://github.com/apache/kylin/pull/689#issuecomment-511190336
# [Codecov](https://codecov.io/gh/apache/kylin/pull/689?src=pr&el=h1) Report
> Merging [#689](https://codecov.io/gh/apache/kylin/pull/689?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/b38fbcaf943a33a80e7400e21da60116266a5d62?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `40%`.
[](https://codecov.io/gh/apache/kylin/pull/689?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #689 +/- ##
============================================
- Coverage 25.74% 25.71% -0.03%
- Complexity 6011 6019 +8
============================================
Files 1385 1387 +2
Lines 82395 82763 +368
Branches 11553 11590 +37
============================================
+ Hits 21209 21283 +74
- Misses 59144 59430 +286
- Partials 2042 2050 +8
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/689?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/kylin/query/util/PushDownUtil.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUHVzaERvd25VdGlsLmphdmE=) | `50.49% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...lin/metadata/expression/BinaryTupleExpression.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvZXhwcmVzc2lvbi9CaW5hcnlUdXBsZUV4cHJlc3Npb24uamF2YQ==) | `42.59% <100%> (ø)` | `17 <0> (ø)` | :arrow_down: |
| [...g/apache/kylin/exception/QueryOnCubeException.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vZXhjZXB0aW9uL1F1ZXJ5T25DdWJlRXhjZXB0aW9uLmphdmE=) | `25% <25%> (ø)` | `1 <1> (?)` | |
| [...ylin/source/jdbc/metadata/JdbcMetadataFactory.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL21ldGFkYXRhL0pkYmNNZXRhZGF0YUZhY3RvcnkuamF2YQ==) | `25% <0%> (-25%)` | `1% <0%> (-4%)` | |
| [...in/source/jdbc/metadata/SQLServerJdbcMetadata.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL21ldGFkYXRhL1NRTFNlcnZlckpkYmNNZXRhZGF0YS5qYXZh) | `85.71% <0%> (-6.6%)` | `4% <0%> (ø)` | |
| [.../kylin/source/jdbc/metadata/MySQLJdbcMetadata.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL21ldGFkYXRhL015U1FMSmRiY01ldGFkYXRhLmphdmE=) | `93.75% <0%> (-6.25%)` | `6% <0%> (ø)` | |
| [...ylin/source/jdbc/metadata/DefaultJdbcMetadata.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL21ldGFkYXRhL0RlZmF1bHRKZGJjTWV0YWRhdGEuamF2YQ==) | `95.83% <0%> (-4.17%)` | `8% <0%> (ø)` | |
| [...c/main/java/org/apache/kylin/jdbc/KylinClient.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9LeWxpbkNsaWVudC5qYXZh) | `62.94% <0%> (-1.28%)` | `37% <0%> (+1%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
| ... and [32 more](https://codecov.io/gh/apache/kylin/pull/689/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/689?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/689?src=pr&el=footer). Last update [b38fbca...e94c511](https://codecov.io/gh/apache/kylin/pull/689?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services