You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/08/05 18:19:10 UTC

[GitHub] [hbase] petersomogyi opened a new pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

petersomogyi opened a new pull request #3568:
URL: https://github.com/apache/hbase/pull/3568


   This is a rework of the original commit to enable
   Hadoop 3 profile for the HBASE-25853 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] petersomogyi commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
petersomogyi commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-893681275


   This is a commit that we don't want to merge back to the base (branch-2) branch once HBASE-25853 is ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894238514


   How about branch-2? This regex will only accept branch-2.x?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] petersomogyi edited a comment on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
petersomogyi edited a comment on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894239912


   > How about branch-2? This regex will only accept branch-2.x?
   
   The regex will accept `branch-2` and `branch-2<anything>` from now on. The previous regex was faulty and allowed `branch-1` too.
   The dot here represents any character, not the actual dot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894243050


   > > How about branch-2? This regex will only accept branch-2.x?
   > 
   > The regex will accept `branch-2` and `branch-2<anything>` from now on. The previous regex was faulty and allowed `branch-1` too.
   
   I'm not an expert of regex in bash but skimmed the script, we also have this
   
   ```
   if [[ "${PATCH_BRANCH}" = branch-1* ]]; then
       yetus_info "Setting Hadoop 3 versions to test based on branch-1.x rules."
       hbase_hadoop3_versions=""
   ```
   
   Is this also wrong?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-895075067






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] petersomogyi commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
petersomogyi commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894253004


   I'll fix these regexes as well.
   
   > What does the dot actually mean here? It means the dot itself or any char?
   
   The dot means any character.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] taklwu merged pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
taklwu merged pull request #3568:
URL: https://github.com/apache/hbase/pull/3568


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] petersomogyi commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
petersomogyi commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894272227


   Using `=` or `=~` is handled differently. The first uses pattern matching the latter uses regex.
   
   ```
   bash-5.1$ export PATCH_BRANCH=branch-1; if [[ "${PATCH_BRANCH}" = branch-1* ]]; then echo "true"; fi
   true
   bash-5.1$ export PATCH_BRANCH=branch-1.2; if [[ "${PATCH_BRANCH}" = branch-1* ]]; then echo "true"; fi
   true
   bash-5.1$ export PATCH_BRANCH=branch-2; if [[ "${PATCH_BRANCH}" = branch-1* ]]; then echo "true"; fi
   bash-5.1$ export PATCH_BRANCH=branch-; if [[ "${PATCH_BRANCH}" = branch-1* ]]; then echo "true"; fi
   
   bash-5.1$ export PATCH_BRANCH=branch-1; if [[ "${PATCH_BRANCH}" =~ branch-1* ]]; then echo "true"; fi
   true
   bash-5.1$ export PATCH_BRANCH=branch-1.2; if [[ "${PATCH_BRANCH}" =~ branch-1* ]]; then echo "true"; fi
   true
   bash-5.1$ export PATCH_BRANCH=branch-2; if [[ "${PATCH_BRANCH}" =~ branch-1* ]]; then echo "true"; fi
   true
   bash-5.1$ export PATCH_BRANCH=branch-; if [[ "${PATCH_BRANCH}" =~ branch-1* ]]; then echo "true"; fi
   true
   
   bash-5.1$ export PATCH_BRANCH=branch-1; if [[ "${PATCH_BRANCH}" =~ branch-1.* ]]; then echo "true"; fi
   true
   bash-5.1$ export PATCH_BRANCH=branch-1.2; if [[ "${PATCH_BRANCH}" =~ branch-1.* ]]; then echo "true"; fi
   true
   bash-5.1$ export PATCH_BRANCH=branch-2; if [[ "${PATCH_BRANCH}" =~ branch-1.* ]]; then echo "true"; fi
   bash-5.1$ export PATCH_BRANCH=branch-; if [[ "${PATCH_BRANCH}" =~ branch-1.* ]]; then echo "true"; fi
   ```
   Based on this I can simplify the code. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-895076120


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  8s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ HBASE-25853 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  6s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  whitespace  |   0m  1s |  The patch has no whitespace issues.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  1s |  ASF License check generated no output?  |
   |  |   |   2m 52s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3568/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3568 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux c63871027497 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-25853 / 4fbc4c29f2 |
   | Max. process+thread count | 46 (vs. ulimit of 12500) |
   | modules | C:  U:  |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3568/2/console |
   | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-893683060






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894244142


   But also this
   
   ```
   elif [[ "${PATCH_BRANCH}" = branch-2.* ]]; then
       yetus_info "Setting Hadoop 2 versions to test based on branch-2.3+ rules."
   ```
   
   I'm a bit confused now...
   What does the dot actually mean here? It means the dot itself or any char?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-893683714






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-893684728


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 53s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ HBASE-25853 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  8s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  1s |  ASF License check generated no output?  |
   |  |   |   3m 42s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3568/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3568 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux c75ac2cee549 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-25853 / 4fbc4c29f2 |
   | Max. process+thread count | 47 (vs. ulimit of 12500) |
   | modules | C:  U:  |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3568/1/console |
   | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-895075647






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] taklwu commented on a change in pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
taklwu commented on a change in pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#discussion_r685300460



##########
File path: dev-support/hbase-personality.sh
##########
@@ -464,7 +465,8 @@ function shadedjars_rebuild
   # If we have HADOOP_PROFILE specified and we're on branch-2.x, pass along
   # the hadoop.profile system property. Ensures that Hadoop2 and Hadoop3
   # logic is not both activated within Maven.
-  if [[ -n "${HADOOP_PROFILE}" ]] && [[ "${PATCH_BRANCH}" =~ branch-2* ]] ; then
+    if [[ -n "${HADOOP_PROFILE}" ]] \

Review comment:
       nit: this lines seems to have two extra spaces before `if`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] petersomogyi commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
petersomogyi commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894274406


   I've modified the PR for master. Please take a look at #3567. I'll update this PR for the feature branch once master is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] petersomogyi commented on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
petersomogyi commented on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894239912


   > How about branch-2? This regex will only accept branch-2.x?
   
   The regex will accept branch-2 and branch-2<anything> from now on. The previous regex was faulty and allowed `branch-1` too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hbase] petersomogyi edited a comment on pull request #3568: HBASE-26176 Correct regex in hbase-personality.sh

Posted by GitBox <gi...@apache.org>.
petersomogyi edited a comment on pull request #3568:
URL: https://github.com/apache/hbase/pull/3568#issuecomment-894239912


   > How about branch-2? This regex will only accept branch-2.x?
   
   The regex will accept `branch-2` and `branch-2<anything>` from now on. The previous regex was faulty and allowed `branch-1` too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org