You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "jojocodeX (via GitHub)" <gi...@apache.org> on 2023/02/15 15:55:35 UTC

[GitHub] [dubbo] jojocodeX commented on a diff in pull request #11574: Enhance the way to get dubbo version

jojocodeX commented on code in PR #11574:
URL: https://github.com/apache/dubbo/pull/11574#discussion_r1107313511


##########
pom.xml:
##########
@@ -800,6 +801,11 @@
                     <artifactId>jetty-maven-plugin</artifactId>
                     <version>${maven_jetty_version}</version>
                 </plugin>
+                <plugin>
+                    <groupId>pl.project13.maven</groupId>
+                    <artifactId>git-commit-id-plugin</artifactId>
+                    <version>${maven_git_version}</version>
+                </plugin>

Review Comment:
   有一个疑问，当前这个版本是全局只有一个版本，还是会根据artifactId生成不同的版本，类似这样的信息
   + spring-boot-test.version=0.0.1-SNAPSHOT
   + spring-boot-test.buildDate=2023-02-15 23\:21\:10 +0800
   + spring-boot-test.commitDate=2022-05-27 09\:35\:11 +0800
   + spring-boot-test.shortCommitHash=a56b7a4
   spring-boot-+ test.longCommitHash=a56b7a406ad963d29c93b77f3d0e61abb0c80f6b
   + spring-boot-test.repoStatus=dirty
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org