You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/04/24 10:54:05 UTC
[jira] Created: (HARMONY-399)
test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit
exception handling convention.
test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit exception handling convention.
------------------------------------------------------------------------------------------------------
Key: HARMONY-399
URL: http://issues.apache.org/jira/browse/HARMONY-399
Project: Harmony
Type: Test
Components: Classlib
Reporter: Richard Liang
Priority: Trivial
The following code doesn't follow JUnit exception handling convention.
try {
Inet6Address.getByAddress("123", addr2, 3);
} catch (UnknownHostException e) {
fail("no exception should be thrown");
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-399)
test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit
exception handling convention.
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-399?page=comments#action_12375993 ]
Richard Liang commented on HARMONY-399:
---------------------------------------
Hi, Tim
The fix looks good.
Please close this issue.
Thanks a lot.
> test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-399
> URL: http://issues.apache.org/jira/browse/HARMONY-399
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Priority: Trivial
> Attachments: luni.src.diff
>
> The following code doesn't follow JUnit exception handling convention.
> try {
> Inet6Address.getByAddress("123", addr2, 3);
> } catch (UnknownHostException e) {
> fail("no exception should be thrown");
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-399)
test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit
exception handling convention.
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-399?page=all ]
Richard Liang updated HARMONY-399:
----------------------------------
Attachment: luni.src.diff
Hello,
The patch fixes the exception handling convention problem, and also removes the duplicated test code.
Would you please have a try?
Thanks a lot!
> test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-399
> URL: http://issues.apache.org/jira/browse/HARMONY-399
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Richard Liang
> Priority: Trivial
> Attachments: luni.src.diff
>
> The following code doesn't follow JUnit exception handling convention.
> try {
> Inet6Address.getByAddress("123", addr2, 3);
> } catch (UnknownHostException e) {
> fail("no exception should be thrown");
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-399)
test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit
exception handling convention.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-399?page=all ]
Tim Ellison resolved HARMONY-399:
---------------------------------
Resolution: Fixed
Thanks Richard,
Patch applied to modules\luni\src\test\java\tests\api\java\net\Inet6AddressTest.java at repo revision 396484.
Please check that the patch was applied as you expected.
> test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-399
> URL: http://issues.apache.org/jira/browse/HARMONY-399
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Priority: Trivial
> Attachments: luni.src.diff
>
> The following code doesn't follow JUnit exception handling convention.
> try {
> Inet6Address.getByAddress("123", addr2, 3);
> } catch (UnknownHostException e) {
> fail("no exception should be thrown");
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-399)
test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit
exception handling convention.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-399?page=all ]
Tim Ellison reassigned HARMONY-399:
-----------------------------------
Assign To: Tim Ellison
> test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-399
> URL: http://issues.apache.org/jira/browse/HARMONY-399
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Priority: Trivial
> Attachments: luni.src.diff
>
> The following code doesn't follow JUnit exception handling convention.
> try {
> Inet6Address.getByAddress("123", addr2, 3);
> } catch (UnknownHostException e) {
> fail("no exception should be thrown");
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-399)
test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit
exception handling convention.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-399?page=all ]
Tim Ellison closed HARMONY-399:
-------------------------------
Verified by Richard.
> test/java/tests/api/java/net/Inet6AddressTest.java doesn't follow JUnit exception handling convention.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-399
> URL: http://issues.apache.org/jira/browse/HARMONY-399
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Priority: Trivial
> Attachments: luni.src.diff
>
> The following code doesn't follow JUnit exception handling convention.
> try {
> Inet6Address.getByAddress("123", addr2, 3);
> } catch (UnknownHostException e) {
> fail("no exception should be thrown");
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira