[GitHub] [spark] hvanhovell commented on a diff in pull request #40315: [SPARK-42699][CONNECTOR] SparkConnectServer should make client and AM same exit code

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #40315:
URL: https://github.com/apache/spark/pull/40315#discussion_r1127848561


##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -736,13 +736,15 @@ class SparkSession private(
   }
   // scalastyle:on
 
+  def stop(): Unit = stop(0)
+
   /**
    * Stop the underlying `SparkContext`.
    *
    * @since 2.0.0
    */
-  def stop(): Unit = {
-    sparkContext.stop()
+  def stop(exitCode: Int = 0): Unit = {

Review Comment:
   @AngersZhuuuu this is a breaking change. You will need to define two stop methods, one with the status code, and one without.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org