Re: Review Request 28082: Disable building static libraries

["Timothy St. Clair" <ts...@redhat.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28082/#review63801
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy St. Clair


On Nov. 15, 2014, 2:17 a.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28082/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2014, 2:17 a.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Shrinks the size resulting from a 'make install' considerably.
> 
> On a build with the options:
> ../configure --enable-optimize build
> 
> du -h of the install directory gives:
> 52MB with patch
> 113MB without patch
> 
> Debug builds the difference will be even more noticeable.
> 
> Distribution packaging guidelines for Debian, Fedora, and Ubuntu all remove static libraries. In the few cases where someone needs a static library, it is still buildable. Developers should be linking against the dynamic libmesos.
> 
> The rest of the unnecessary size comes from 2 places
> 
>  - 22MB We effectively have two copies of libmesos (libmesos.so, and one in the python native binding)
>  - 5-15MB We export all symbols in the .so, rather than just the necessary ones (Combination of lots of extra strings in the binary, and excess non-optimizable code).
> 
> 
> Diffs
> -----
> 
>   configure.ac c287a17307fb821fc04ded67ff9f33d27947e5d7 
> 
> Diff: https://reviews.apache.org/r/28082/diff/
> 
> 
> Testing
> -------
> 
> Built and compared install directory sizes on local machine
> Make distcheck on ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>