You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/10 00:08:52 UTC
Review Request: FLAGS (4): Moved webui components from 'common' to 'webui'
directory.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5857/
-----------------------------------------------------------
Review request for mesos, John Sirois and Vinod Kone.
Description
-------
This refactor has little to do with the configuration/flags transition, but was necessary to make some things "cleaner".
Diffs
-----
src/Makefile.am 11f6b4c
src/common/webui_utils.hpp 7ac3120
src/common/webui_utils.cpp 6915190
src/master/webui.cpp 56134b7
src/slave/webui.cpp 5616542
src/webui/webui.hpp PRE-CREATION
src/webui/webui.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/5857/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: FLAGS (4): Moved webui components from 'common' to
'webui' directory.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 11, 2012, 4:52 p.m., John Sirois wrote:
> > src/webui/webui.cpp, line 123
> > <https://reviews.apache.org/r/5857/diff/1/?file=120803#file120803line123>
> >
> > Why is this hanging around? Missing TODO?
It gets killed in a later review.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5857/#review9065
-----------------------------------------------------------
On July 9, 2012, 10:08 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5857/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 10:08 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> This refactor has little to do with the configuration/flags transition, but was necessary to make some things "cleaner".
>
>
> Diffs
> -----
>
> src/Makefile.am 11f6b4c
> src/common/webui_utils.hpp 7ac3120
> src/common/webui_utils.cpp 6915190
> src/master/webui.cpp 56134b7
> src/slave/webui.cpp 5616542
> src/webui/webui.hpp PRE-CREATION
> src/webui/webui.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5857/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: FLAGS (4): Moved webui components from 'common' to
'webui' directory.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5857/#review9065
-----------------------------------------------------------
Ship it!
src/webui/webui.cpp
<https://reviews.apache.org/r/5857/#comment19208>
Why is this hanging around? Missing TODO?
- John Sirois
On July 9, 2012, 10:08 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5857/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 10:08 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> This refactor has little to do with the configuration/flags transition, but was necessary to make some things "cleaner".
>
>
> Diffs
> -----
>
> src/Makefile.am 11f6b4c
> src/common/webui_utils.hpp 7ac3120
> src/common/webui_utils.cpp 6915190
> src/master/webui.cpp 56134b7
> src/slave/webui.cpp 5616542
> src/webui/webui.hpp PRE-CREATION
> src/webui/webui.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5857/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>