You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/04/08 21:15:40 UTC

Review Request 32985: HIVE-3299 Create UDF DAYNAME(date)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32985/
-----------------------------------------------------------

Review request for hive and Jason Dere.


Bugs: HIVE-3299
    https://issues.apache.org/jira/browse/HIVE-3299


Repository: hive-git


Description
-------

HIVE-3299 Create UDF DAYNAME(date)


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 8e1b98bd23a2474af903383c27ea970906bc55d1 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDayName.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDayName.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_dayname.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out cb54c6f7e66bdf707029048cde34a250dd4a86b1 
  ql/src/test/results/clientpositive/udf_dayname.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/32985/diff/


Testing
-------


Thanks,

Alexander Pivovarov

Re: Review Request 32985: HIVE-3299 Create UDF DAYNAME(date)

Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32985/
-----------------------------------------------------------

(Updated April 9, 2015, 7:11 p.m.)


Review request for hive and Jason Dere.


Changes
-------

fixed show_functions.q.out


Bugs: HIVE-3299
    https://issues.apache.org/jira/browse/HIVE-3299


Repository: hive-git


Description
-------

HIVE-3299 Create UDF DAYNAME(date)


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 8e1b98bd23a2474af903383c27ea970906bc55d1 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDayName.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDayName.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_dayname.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out cb54c6f7e66bdf707029048cde34a250dd4a86b1 
  ql/src/test/results/clientpositive/udf_dayname.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/32985/diff/


Testing
-------


Thanks,

Alexander Pivovarov

Re: Review Request 32985: HIVE-3299 Create UDF DAYNAME(date)

Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32985/
-----------------------------------------------------------

(Updated April 9, 2015, 5:29 p.m.)


Review request for hive and Jason Dere.


Changes
-------

fixed typo in q file


Bugs: HIVE-3299
    https://issues.apache.org/jira/browse/HIVE-3299


Repository: hive-git


Description
-------

HIVE-3299 Create UDF DAYNAME(date)


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 8e1b98bd23a2474af903383c27ea970906bc55d1 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDayName.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDayName.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_dayname.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out cb54c6f7e66bdf707029048cde34a250dd4a86b1 
  ql/src/test/results/clientpositive/udf_dayname.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/32985/diff/


Testing
-------


Thanks,

Alexander Pivovarov

Re: Review Request 32985: HIVE-3299 Create UDF DAYNAME(date)

Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32985/
-----------------------------------------------------------

(Updated April 9, 2015, 5:14 a.m.)


Review request for hive and Jason Dere.


Changes
-------

fixed GenericUDFDayName class comments


Bugs: HIVE-3299
    https://issues.apache.org/jira/browse/HIVE-3299


Repository: hive-git


Description
-------

HIVE-3299 Create UDF DAYNAME(date)


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 8e1b98bd23a2474af903383c27ea970906bc55d1 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDayName.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDayName.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_dayname.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out cb54c6f7e66bdf707029048cde34a250dd4a86b1 
  ql/src/test/results/clientpositive/udf_dayname.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/32985/diff/


Testing
-------


Thanks,

Alexander Pivovarov