You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/06/06 20:06:27 UTC
Re: svn commit: r31616 - trunk
pburba@tigris.org writes:
> Follow-up to r31614, the fix for issue #1796. Fix windows build.
>
> * build.conf
> (libsvn_subr): Add private\svn_utf_private.h to msvc-export list.
Thanks, Paul. Was there anything I could have done to remember that,
aside from, er, remember it?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r31616 - trunk
Posted by Lieven Govaerts <sv...@mobsol.be>.
Paul Burba wrote:
> On Fri, Jun 6, 2008 at 4:06 PM, Karl Fogel <kf...@red-bean.com> wrote:
>
>> pburba@tigris.org writes:
>>
>>> Follow-up to r31614, the fix for issue #1796. Fix windows build.
>>>
>>> * build.conf
>>> (libsvn_subr): Add private\svn_utf_private.h to msvc-export list.
>>>
>> Thanks, Paul. Was there anything I could have done to remember that,
>> aside from, er, remember it?
>>
>
> Start developing on Windows? :-) Seriously, that's what the buildbots
> are for no? We've all broken other platform's builds (well I
> certainly have anyway). Took all of 5 minutes to fix, if that, so
> it's not a problem.
>
+1.
I had the same question when I saw your commit and came to the same
conclusion as Paul. Why adding a new 'rule' and making sure all
committers remember it, where a) this situation occurs only a few times
a year and b) the workaround takes only 10 minutes to execute.
We could make gen-make.py smart enough to include all files in
/include/private in the msvc export list, but for me it's not worth the
effort.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r31616 - trunk
Posted by Paul Burba <pt...@gmail.com>.
On Fri, Jun 6, 2008 at 4:06 PM, Karl Fogel <kf...@red-bean.com> wrote:
> pburba@tigris.org writes:
>> Follow-up to r31614, the fix for issue #1796. Fix windows build.
>>
>> * build.conf
>> (libsvn_subr): Add private\svn_utf_private.h to msvc-export list.
>
> Thanks, Paul. Was there anything I could have done to remember that,
> aside from, er, remember it?
Start developing on Windows? :-) Seriously, that's what the buildbots
are for no? We've all broken other platform's builds (well I
certainly have anyway). Took all of 5 minutes to fix, if that, so
it's not a problem.
Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org