You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by ka...@apache.org on 2016/08/31 08:23:40 UTC
[1/2] storm git commit: STORM-1890: looks like too many calls were
moved to getStatic. It doesnt break things, but it is sloppy,
so reverting some to $.get
Repository: storm
Updated Branches:
refs/heads/master b3d6359b1 -> f547f3faf
STORM-1890: looks like too many calls were moved to getStatic. It doesnt break things, but it is sloppy, so reverting some to $.get
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/3c9e27b9
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/3c9e27b9
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/3c9e27b9
Branch: refs/heads/master
Commit: 3c9e27b94bcc69a95ee921b9b0837c178dfaed5b
Parents: 726f3ea
Author: Alessandro Bellina <ab...@yahoo-inc.com>
Authored: Wed Jul 27 22:37:40 2016 -0500
Committer: Alessandro Bellina <ab...@yahoo-inc.com>
Committed: Fri Aug 5 13:36:05 2016 -0500
----------------------------------------------------------------------
storm-core/src/ui/public/component.html | 19 ++++++++-----------
storm-core/src/ui/public/deep_search_result.html | 4 ++--
storm-core/src/ui/public/topology.html | 2 +-
3 files changed, 11 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/3c9e27b9/storm-core/src/ui/public/component.html
----------------------------------------------------------------------
diff --git a/storm-core/src/ui/public/component.html b/storm-core/src/ui/public/component.html
index 005ac5d..dc0804b 100644
--- a/storm-core/src/ui/public/component.html
+++ b/storm-core/src/ui/public/component.html
@@ -341,7 +341,7 @@ function start_profiling() {
var passed = {}
Object.keys(workerActionSelected).forEach(function (id) {
var url = "/api/v1/topology/"+topologyId+"/profiling/start/" + id + "/" + timeout;
- getStatic(url, function(response,status,jqXHR) {
+ $.get(url, function(response,status,jqXHR) {
jsError(function() {
getStatic("/templates/component-page-template.html", function(template) {
var host_port_split = id.split(":");
@@ -382,7 +382,7 @@ function stop_profiling(id) {
$("#stop_" + id).prop('disabled', true);
setTimeout(function(){ $("#stop_" + id).prop('disabled', false); }, 5000);
- getStatic(url, function(response,status,jqXHR) {
+ $.get(url, function(response,status,jqXHR) {
alert("Submitted request to stop profiling...");
})
.fail(function(response) {
@@ -398,7 +398,7 @@ function dump_profile(id) {
$("#dump_profile_" + id).prop('disabled', true);
setTimeout(function(){ $("#dump_profile_" + id).prop('disabled', false); }, 5000);
- getStatic(url, function(response,status,jqXHR) {
+ $.get(url, function(response,status,jqXHR) {
alert("Submitted request to dump profile snapshot...");
})
.fail(function(response) {
@@ -418,8 +418,7 @@ function dump_jstacks() {
$("#dump_jstack_" + id).prop('disabled', true);
setTimeout(function(){ $("#dump_jstack_" + id).prop('disabled', false); }, 5000);
- getStatic(url)
- .fail(function(response) {
+ $.get(url).fail(function(response) {
failed[id] = response;
});
if (!(id in failed)) {
@@ -443,7 +442,7 @@ function dump_jstack(id) {
$("#dump_jstack_" + id).prop('disabled', true);
setTimeout(function(){ $("#dump_jstack_" + id).prop('disabled', false); }, 5000);
- getStatic(url, function(response,status,jqXHR) {
+ $.get(url, function(response,status,jqXHR) {
alert("Submitted request for jstack dump...");
})
.fail(function(response) {
@@ -461,8 +460,7 @@ function restart_worker_jvms() {
$("#restart_worker_jvm_" + id).prop('disabled', true);
setTimeout(function(){ $("#restart_worker_jvm_" + id).prop('disabled', false); }, 5000);
- getStatic(url)
- .fail(function(response) {
+ $.get(url).fail(function(response) {
failed[id] = response;
});
if (!(id in failed)) {
@@ -489,8 +487,7 @@ function dump_heaps() {
$("#dump_heap_" + id).prop('disabled', true);
setTimeout(function(){ $("#dump_heap_" + id).prop('disabled', false); }, 5000);
- getStatic(url)
- .fail(function(response) {
+ $.get(url).fail(function(response) {
failed[id] = response;
});
if (!(id in failed)) {
@@ -514,7 +511,7 @@ function dump_heap(id) {
$("#dump_heap_" + id).prop('disabled', true);
setTimeout(function(){ $("#dump_heap_" + id).prop('disabled', false); }, 5000);
- getStatic(url, function(response,status,jqXHR) {
+ $.get(url, function(response,status,jqXHR) {
alert("Submitted request for jmap dump...");
})
.fail(function(response) {
http://git-wip-us.apache.org/repos/asf/storm/blob/3c9e27b9/storm-core/src/ui/public/deep_search_result.html
----------------------------------------------------------------------
diff --git a/storm-core/src/ui/public/deep_search_result.html b/storm-core/src/ui/public/deep_search_result.html
index 5b4f47b..5de2ab8 100644
--- a/storm-core/src/ui/public/deep_search_result.html
+++ b/storm-core/src/ui/public/deep_search_result.html
@@ -61,7 +61,7 @@ $(document).ready(function() {
if (search_archived) {
checked = "checked";
}
- getStatic("/api/v1/history/summary", function (response, status, jqXHR) {
+ $.get("/api/v1/history/summary", function (response, status, jqXHR) {
var findIds = function findIds(query, cb) {
var found = [];
var re = new RegExp(query, 'i');
@@ -104,7 +104,7 @@ $(document).ready(function() {
var result = $("#result");
if(search) {
- getStatic("/api/v1/supervisor/summary", function(response, status, jqXHR) {
+ $.get("/api/v1/supervisor/summary", function(response, status, jqXHR) {
for(var i in response.supervisors) {
response.supervisors[i].elemId = elem_id_for_host(response.supervisors[i].host);
http://git-wip-us.apache.org/repos/asf/storm/blob/3c9e27b9/storm-core/src/ui/public/topology.html
----------------------------------------------------------------------
diff --git a/storm-core/src/ui/public/topology.html b/storm-core/src/ui/public/topology.html
index 0f7cf9a..48941ea 100644
--- a/storm-core/src/ui/public/topology.html
+++ b/storm-core/src/ui/public/topology.html
@@ -230,7 +230,7 @@ function renderLogLevelForm (template, responseData){
};
if (!responseData) {
var topologyId = $.url("?id");
- getStatic ('/api/v1/topology/' + topologyId + '/logconfig', renderImpl);
+ $.get('/api/v1/topology/' + topologyId + '/logconfig', renderImpl);
} else {
renderImpl (responseData);
}
[2/2] storm git commit: Merge branch
'STORM-1890_remove_unnecessary_calls_to_getStatic' of
https://github.com/abellina/storm into STORM-1890
Posted by ka...@apache.org.
Merge branch 'STORM-1890_remove_unnecessary_calls_to_getStatic' of https://github.com/abellina/storm into STORM-1890
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/f547f3fa
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/f547f3fa
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/f547f3fa
Branch: refs/heads/master
Commit: f547f3faffd93b1fcaac8858ec61c8861fc4fd1d
Parents: b3d6359 3c9e27b
Author: Jungtaek Lim <ka...@gmail.com>
Authored: Wed Aug 31 17:22:14 2016 +0900
Committer: Jungtaek Lim <ka...@gmail.com>
Committed: Wed Aug 31 17:22:14 2016 +0900
----------------------------------------------------------------------
storm-core/src/ui/public/component.html | 19 ++++++++-----------
storm-core/src/ui/public/deep_search_result.html | 4 ++--
storm-core/src/ui/public/topology.html | 2 +-
3 files changed, 11 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/f547f3fa/storm-core/src/ui/public/component.html
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/f547f3fa/storm-core/src/ui/public/topology.html
----------------------------------------------------------------------