You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by kwmonroe <gi...@git.apache.org> on 2016/06/06 20:49:56 UTC
[GitHub] bigtop pull request #114: BIGTOP-2472: zeppelin puppet module needs to expos...
GitHub user kwmonroe opened a pull request:
https://github.com/apache/bigtop/pull/114
BIGTOP-2472: zeppelin puppet module needs to expose ZEPPELIN_WAR_TEMPDIR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juju-solutions/bigtop BIGTOP-2472
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #114
----
commit 4177d2ed8ed1d4162a47fbeb28d53b3516eb6b90
Author: Kevin W Monroe <ke...@canonical.com>
Date: 2016-06-06T20:25:43Z
BIGTOP-2472: zeppelin puppet module needs to expose ZEPPELIN_WAR_TEMPDIR
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #114: BIGTOP-2472: zeppelin puppet module needs to expose ZEPPE...
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/114
Negative c0s, your commit is in there, but that only appears to affect the zeppelin deb. Your change to zeppelin-env.sh is not present in the puppet:
https://github.com/apache/bigtop/blob/master/bigtop-deploy/puppet/modules/zeppelin/templates/zeppelin-env.sh
So I'm guessing puppet installs the zeppelin deb (which does the right thing), but then it goes off and overwrites the /etc/zeppelin/conf/zeppelin-env.sh with its template from ./bigtop-deploy/puppet/modules/zeppelin/templates.
This PR is to ensure your changes from:
bigtop-packages/src/common/zeppelin/zeppelin-env.sh
make it into:
bigtop-deploy/puppet/modules/zeppelin/templates/zeppelin-env.sh
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #114: BIGTOP-2472: zeppelin puppet module needs to expose ZEPPE...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/114
Interesting, I have fixed this back in Jan as
a97479a9d37d7c94f5128f36df2bad8b3676d2c2
Are you saying this change is gone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #114: BIGTOP-2472: zeppelin puppet module needs to expose ZEPPE...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the issue:
https://github.com/apache/bigtop/pull/114
oh yeah, makes sense! +1 will commit it in a bit. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #114: BIGTOP-2472: zeppelin puppet module needs to expose ZEPPE...
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe commented on the issue:
https://github.com/apache/bigtop/pull/114
This came in with:
https://github.com/apache/bigtop/commit/9299713a2c59b7c605ec8a3d118244562485bf59
Closing out PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #114: BIGTOP-2472: zeppelin puppet module needs to expos...
Posted by kwmonroe <gi...@git.apache.org>.
Github user kwmonroe closed the pull request at:
https://github.com/apache/bigtop/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---