You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/17 07:09:07 UTC

[GitHub] [skywalking-banyandb] lujiajing1126 opened a new pull request #41: Fix docker CI

lujiajing1126 opened a new pull request #41:
URL: https://github.com/apache/skywalking-banyandb/pull/41


   Signed-off-by: Megrez Lu <lu...@gmail.com>
   
   1. Run docker build for both PR and main branch
   2. Skip docker push for PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-banyandb] hanahmily merged pull request #41: Fix docker CI

Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #41:
URL: https://github.com/apache/skywalking-banyandb/pull/41


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #41: Fix docker CI

Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #41:
URL: https://github.com/apache/skywalking-banyandb/pull/41#issuecomment-900099574


   Ping @Fine0830 . Gprc tests failure?
   
   ```
   --- FAIL: TestTraceService (0.22s)
       --- FAIL: TestTraceService/noTLS (0.00s)
           trace_test.go:294: 
               	Error Trace:	trace_test.go:294
               	            				trace_test.go:253
               	            				trace_test.go:242
               	Error:      	"[]" should have 1 item(s), but has 0
               	Test:       	TestTraceService/noTLS
   FAIL
   FAIL	github.com/apache/skywalking-banyandb/banyand/liaison/grpc	0.225s
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #41: Fix docker CI

Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #41:
URL: https://github.com/apache/skywalking-banyandb/pull/41#issuecomment-900106354


   @kezhenxu94 Do we need to setup `GITHUB_TOKEN` for docker image pushing? Or it is automatically setup?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-banyandb] kezhenxu94 commented on pull request #41: Fix docker CI

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #41:
URL: https://github.com/apache/skywalking-banyandb/pull/41#issuecomment-900107220


   > Ping @Fine0830 . Gprc tests failure?
   > 
   > 
   > 
   > ```
   > 
   > --- FAIL: TestTraceService (0.22s)
   > 
   >     --- FAIL: TestTraceService/noTLS (0.00s)
   > 
   >         trace_test.go:294: 
   > 
   >             	Error Trace:	trace_test.go:294
   > 
   >             	            				trace_test.go:253
   > 
   >             	            				trace_test.go:242
   > 
   >             	Error:      	"[]" should have 1 item(s), but has 0
   > 
   >             	Test:       	TestTraceService/noTLS
   > 
   > FAIL
   > 
   > FAIL	github.com/apache/skywalking-banyandb/banyand/liaison/grpc	0.225s
   > 
   > ```
   
   This test is flaky and failed now and the.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-banyandb] kezhenxu94 commented on pull request #41: Fix docker CI

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #41:
URL: https://github.com/apache/skywalking-banyandb/pull/41#issuecomment-900106890


   > @kezhenxu94 Do we need to setup `GITHUB_TOKEN` for docker image pushing? Or it is automatically setup?
   
   It's built-in env var automatically set by GitHub.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org