You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2017/01/27 18:52:28 UTC

[GitHub] flink pull request #3229: [FLINK-5663] Prevent leaking SafetyNetCloseableReg...

GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/3229

    [FLINK-5663] Prevent leaking SafetyNetCloseableRegistry through Inher\u2026

    This PR prevents the SafetyNetCloseableRegistry from leaking into pooled threads through InheritableThreadLocal.
    
    As first step, we use ThreadLocal instead of InheritableThreadLocal to hold the closeable registries.
    
    Additionally, we also create safety nets for the file system at the scope of the checkpointing thread. We hope that this covers already covers most cases. Other threads could actually also create safety nets for their scope right now.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink safetyNetThreadLocal

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3229
    
----
commit 31ae956fdd83a2f65bf22c3ad601d4d65ad61439
Author: Stefan Richter <s....@data-artisans.com>
Date:   2017-01-27T18:47:12Z

    [FLINK-5663] Prevent leaking SafetyNetCloseableRegistry through InheritableThreadLocal

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3229: [FLINK-5663] Prevent leaking SafetyNetCloseableRegistry t...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/3229
  
    Thank you for reviewing the PR!
    I'll create RC3 afterwards.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3229: [FLINK-5663] Prevent leaking SafetyNetCloseableRegistry t...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3229
  
    Looks good to me, merging this for `1.2` and `master`...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3229: [FLINK-5663] Prevent leaking SafetyNetCloseableReg...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---