You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/30 11:48:39 UTC
[GitHub] [incubator-dolphinscheduler] clay4444 opened a new pull request
#1645: fix zkMonitor bug
clay4444 opened a new pull request #1645: fix zkMonitor bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1645
## What is the purpose of the pull request
This pull request is for fix bug in MonitorService
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1645:
fix zkMonitor bug
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1645: fix zkMonitor bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1645#issuecomment-569657373
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`dev@2106374`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1645 +/- ##
======================================
Coverage ? 13.41%
======================================
Files ? 282
Lines ? 13906
Branches ? 2249
======================================
Hits ? 1866
Misses ? 11834
Partials ? 206
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/api/service/MonitorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTW9uaXRvclNlcnZpY2UuamF2YQ==) | `22.72% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=footer). Last update [2106374...e25342c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1645:
fix zkMonitor bug
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1645: fix zkMonitor bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1645: fix zkMonitor bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1645: fix zkMonitor bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1645#issuecomment-569657373
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=h1) Report
> Merging [#1645](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/e1d39e1e8e5e283c9e45f80a609013d654579abd?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1645 +/- ##
=========================================
+ Coverage 13.4% 13.41% +<.01%
=========================================
Files 282 282
Lines 13915 13907 -8
Branches 2250 2249 -1
=========================================
Hits 1866 1866
+ Misses 11843 11835 -8
Partials 206 206
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/api/service/MonitorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTW9uaXRvclNlcnZpY2UuamF2YQ==) | `21.73% <0%> (+5.61%)` | :arrow_up: |
| [...a/org/apache/dolphinscheduler/dao/entity/User.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Vc2VyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=footer). Last update [e1d39e1...b549ee3](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in
pull request #1645: fix zkMonitor bug
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1645: fix zkMonitor bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1645#discussion_r362135266
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/MonitorService.java
##########
@@ -116,20 +118,9 @@
}
public List<Server> getServerListFromZK(boolean isMaster){
- List<Server> servers = new ArrayList<>();
- ZookeeperMonitor zookeeperMonitor = null;
- try{
- zookeeperMonitor = new ZookeeperMonitor();
- ZKNodeType zkNodeType = isMaster ? ZKNodeType.MASTER : ZKNodeType.WORKER;
- servers = zookeeperMonitor.getServersList(zkNodeType);
- }catch (Exception e){
- throw e;
- }finally {
- if(zookeeperMonitor != null){
- zookeeperMonitor.close();
- }
- }
- return servers;
+
+ ZKNodeType zkNodeType = isMaster ? ZKNodeType.MASTER : ZKNodeType.WORKER;
+ return checkNotNull(zookeeperMonitor).getServersList(zkNodeType);
Review comment:
Not build pattern, so do not use like this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services