You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Swapnil Bawaskar <sb...@apache.org> on 2016/02/18 22:16:35 UTC
Review Request 43738: GEODE-905: HLL classes should preserve original
source header
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43738/
-----------------------------------------------------------
Review request for geode and Anthony Baker.
Repository: geode
Description
-------
Restoring the original headers.
GEODE-905: HLL classes should preserve original source header
Adding NOTICE from stream-lib project for HLL classes.
Diffs
-----
NOTICE 7989bba4face1ad1eba68febd96b884bcfac377a
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/Bits.java bd0b33cd1ca2d8b7c697fefdade875f01fe4e91f
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/CardinalityMergeException.java 5fd6b0b04df31272339272298b49fd666b2f5d35
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLog.java fa5508d250e590567ae9f9fd4820742bc3558228
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLogPlus.java 7f04c38bcde16e66cf1659bc563b6774f1303782
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/IBuilder.java bff40cd796adf568608545de2d636b9175933f9d
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/ICardinality.java 1671fe50c75553dc4970729784eaa0e2793550ae
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/MurmurHash.java bab802ecec7496d705749860fc75bfd747d1a082
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/RegisterSet.java e1a1944d0e47a09317b6219857f911a36ae4173f
Diff: https://reviews.apache.org/r/43738/diff/
Testing
-------
Thanks,
Swapnil Bawaskar
Re: Review Request 43738: GEODE-905: HLL classes should preserve
original source header
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43738/#review119729
-----------------------------------------------------------
The binary NOTICE in gemfire-assembly/src/main/dist/NOTICE should be updated also.
NOTICE (line 13)
<https://reviews.apache.org/r/43738/#comment181074>
Lines 13-14 should be:
stream-lib
Copyright 2016 AddThis
This product includes software developed by AddThis.
This product also includes code adapted from:
Apache Solr (http://lucene.apache.org/solr/)
Copyright 2014 The Apache Software Foundation
Apache Mahout (http://mahout.apache.org/)
Copyright 2014 The Apache Software Foundation
- Anthony Baker
On Feb. 18, 2016, 9:16 p.m., Swapnil Bawaskar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43738/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 9:16 p.m.)
>
>
> Review request for geode and Anthony Baker.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Restoring the original headers.
>
> GEODE-905: HLL classes should preserve original source header
>
> Adding NOTICE from stream-lib project for HLL classes.
>
>
> Diffs
> -----
>
> NOTICE 7989bba4face1ad1eba68febd96b884bcfac377a
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/Bits.java bd0b33cd1ca2d8b7c697fefdade875f01fe4e91f
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/CardinalityMergeException.java 5fd6b0b04df31272339272298b49fd666b2f5d35
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLog.java fa5508d250e590567ae9f9fd4820742bc3558228
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLogPlus.java 7f04c38bcde16e66cf1659bc563b6774f1303782
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/IBuilder.java bff40cd796adf568608545de2d636b9175933f9d
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/ICardinality.java 1671fe50c75553dc4970729784eaa0e2793550ae
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/MurmurHash.java bab802ecec7496d705749860fc75bfd747d1a082
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/RegisterSet.java e1a1944d0e47a09317b6219857f911a36ae4173f
>
> Diff: https://reviews.apache.org/r/43738/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapnil Bawaskar
>
>
Re: Review Request 43738: GEODE-905: HLL classes should preserve
original source header
Posted by Swapnil Bawaskar <sb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43738/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 11:22 p.m.)
Review request for geode and Anthony Baker.
Changes
-------
Incorporate Anthony's feedback.
Repository: geode
Description
-------
Restoring the original headers.
GEODE-905: HLL classes should preserve original source header
Adding NOTICE from stream-lib project for HLL classes.
Diffs (updated)
-----
NOTICE 7989bba4face1ad1eba68febd96b884bcfac377a
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/Bits.java bd0b33cd1ca2d8b7c697fefdade875f01fe4e91f
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/CardinalityMergeException.java 5fd6b0b04df31272339272298b49fd666b2f5d35
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLog.java fa5508d250e590567ae9f9fd4820742bc3558228
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLogPlus.java 7f04c38bcde16e66cf1659bc563b6774f1303782
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/IBuilder.java bff40cd796adf568608545de2d636b9175933f9d
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/ICardinality.java 1671fe50c75553dc4970729784eaa0e2793550ae
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/MurmurHash.java bab802ecec7496d705749860fc75bfd747d1a082
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/RegisterSet.java e1a1944d0e47a09317b6219857f911a36ae4173f
Diff: https://reviews.apache.org/r/43738/diff/
Testing
-------
Thanks,
Swapnil Bawaskar