You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <Ar...@GMail.Com> on 2009/10/10 14:22:55 UTC
Re: svn commit: r39844 - trunk/subversion/bindings/swig/include
2009-10-07 22:25:27 Roman Donchenko napisał(a):
> Author: rdonch
> Date: Wed Oct 7 13:25:27 2009
> New Revision: 39844
>
> Log:
> * subversion/bindings/swig/include/svn_containers.swg:
> For now, remove one of the checks introduced by r39838, as is requires
> Py_ssize_t, which is apparently not provided by the combination of old SWIG
> and Python 2.4 which is used by the win32-xp VS2005 buildbot.
The code can be conditional on PY_MAJOR_VERSION and PY_MINOR_VERSION:
#if PY_MAJOR_VERSION >= 3 || (PY_MAJOR_VERSION < 3 && PY_MINOR_VERSION >=5)
/* Code for Python >=2.5. */
#else
/* Code for Python 2.4. */
#endif
--
Arfrever Frehtes Taifersar Arahesis
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405872
Re: svn commit: r39844 - trunk/subversion/bindings/swig/include
Posted by Roman Donchenko <DX...@yandex.ru>.
Arfrever Frehtes Taifersar Arahesis <Ar...@gmail.com> писал в своём
письме Sat, 10 Oct 2009 18:22:55 +0400:
> 2009-10-07 22:25:27 Roman Donchenko napisał(a):
>> Author: rdonch
>> Date: Wed Oct 7 13:25:27 2009
>> New Revision: 39844
>>
>> Log:
>> * subversion/bindings/swig/include/svn_containers.swg:
>> For now, remove one of the checks introduced by r39838, as is
>> requires
>> Py_ssize_t, which is apparently not provided by the combination of
>> old SWIG
>> and Python 2.4 which is used by the win32-xp VS2005 buildbot.
>
> The code can be conditional on PY_MAJOR_VERSION and PY_MINOR_VERSION:
>
> #if PY_MAJOR_VERSION >= 3 || (PY_MAJOR_VERSION < 3 && PY_MINOR_VERSION
> >=5)
> /* Code for Python >=2.5. */
> #else
> /* Code for Python 2.4. */
> #endif
>
Yeah, that's basically what libsvn_swig_py and the newer SWIGs are doing.
I've decided not to copy it to the interface definition files, though,
since I'll soon refactor this typemap so it won't need to refer to
Py_ssize_t directly.
Roman.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405889