You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/04/06 20:19:59 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #23617: fix: Error on Cypress test
michael-s-molina opened a new pull request, #23617:
URL: https://github.com/apache/superset/pull/23617
### SUMMARY
Fixes the Cypress error affecting master.
```
cypress/integration/dashboard/editmode.test
AssertionError: Timed out retrying after 8000ms:
Expected to find element: `[data-test=chart-card]`, but never found it.
```
### TESTING INSTRUCTIONS
All E2E tests should pass.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23617: fix: Error on Cypress test
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23617:
URL: https://github.com/apache/superset/pull/23617#issuecomment-1499646339
## [Codecov](https://codecov.io/gh/apache/superset/pull/23617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23617](https://codecov.io/gh/apache/superset/pull/23617?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c11afd) into [master](https://codecov.io/gh/apache/superset/commit/8d14420d14e572d9101d772e06c5d980f55502b2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d14420) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 7c11afd differs from pull request most recent head 4a0a879. Consider uploading reports for the commit 4a0a879 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23617 +/- ##
=======================================
Coverage 67.68% 67.68%
=======================================
Files 1918 1918
Lines 74133 74133
Branches 8052 8052
=======================================
Hits 50178 50178
Misses 21902 21902
Partials 2053 2053
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.89% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #23617: fix: Error on Cypress test
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23617:
URL: https://github.com/apache/superset/pull/23617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org