[jira] [Resolved] (TRB-88) services.VelocityService.runtime.log not relative

["Georg Kallidis (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TRB-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Georg Kallidis resolved TRB-88.
-------------------------------

    Resolution: Fixed

Turbine Core 4.0-M2 uses velocity version 1.6.4 and has as default Log4J initialized. The runtime.log paramter is not used in this case.

Cft org.apache.turbine.services.velocity.TurbineVelocityService.initVelocity() and http://velocity.apache.org/engine/devel/developer-guide.html#Configuring_Logging. 
                
> services.VelocityService.runtime.log not relative
> -------------------------------------------------
>
>                 Key: TRB-88
>                 URL: https://issues.apache.org/jira/browse/TRB-88
>             Project: Turbine
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: Core 2.3.3
>         Environment: Windows XP
>            Reporter: Georg Kallidis
>            Assignee: Georg Kallidis
>            Priority: Minor
>             Fix For: Core 4.0-M2
>
>
> The definition in TR.properties of the velocity log is
> services.VelocityService.runtime.log=/log/velocity.log
> If using the default class org.apache.turbine.services.velocity.TurbineVelocityService as the VelocityService  the method 
> public ExtendedProperties createVelocityProperties(Configuration conf)
> is called when the service is initialized. At the beginning this check is used: 
> if (!key.endsWith(RESOURCE_LOADER_PATH) {... continue } 
> and only after this pathes are resolved relative to the web-app. 
> If you consider this, then e.g defining runtime.log as above you end up (in may case) with a log in C:/log/velocity.log. 
> I would propose changing the line to
> if (!key.endsWith(RESOURCE_LOADER_PATH) && !key.endsWith("runtime.log"))
> or applying a change to make the condition check configurable ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira