[GitHub] kiwiflyer commented on a change in pull request #2878: Fixed Issue 2868, libvirt resize notify failure

[GitBox <gi...@apache.org>]

kiwiflyer commented on a change in pull request #2878: Fixed Issue 2868, libvirt resize notify failure
URL: https://github.com/apache/cloudstack/pull/2878#discussion_r222985560
 
 

 ##########
 File path: scripts/storage/qcow2/resizevolume.sh
 ##########
 @@ -92,7 +92,8 @@ notifyqemu() {
     if `virsh domstate $vmname >/dev/null 2>&1`
     then
       sizeinkb=$(($newsize/1024))
-      virsh blockresize --domain $vmname --path $path --size $sizeinkb >/dev/null 2>&1
+      devicepath=$(virsh domblklist $vmname|grep $path|tr -s ' ' | cut -d' ' -f1)
 
 Review comment:
   I can change this to use awk. This is  definitely broken on Centos 7.x and Ubuntu 16.04 (tested with Ceph RBD on both). It fails silently and just produces a failure log on the host, but success is returned to the management server, so most folks probably don't realize it's broken.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services