[GitHub] [geode] pivotal-jbarrett commented on issue #4085: GEODE-6927 make getThreadOwnedConnection code thread safe

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

> I don't think we should be using the state of a collection as an indication of whether the service is open or closed. There should be other state that we use to avoid creating a new connection and putting it in the connection map if ConnectionTable is closed.

Couldn't agree more! If you think its safe for connection references that race into the map on close to sit there then this is an easy fix. A simple check if the collection is closed after the put completes could accomplish this. The close itself would empty the map and any race on that operation would get cleared up on the back end after the put by checking for closed state and removing the entry just put.

[ Full content available at: https://github.com/apache/geode/pull/4085 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org