You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/12/07 03:14:15 UTC

Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64400/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Repository: mesos


Description
-------

Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.


Diffs
-----

  include/mesos/resource_provider/resource_provider.proto 2ce71f4c3e97e89c226966c347c2817e2bab9c1b 
  include/mesos/v1/resource_provider/resource_provider.proto 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb 
  src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe 
  src/resource_provider/state.proto ae30d1677a51fa837c19b47515761c30dae5b9d8 
  src/resource_provider/storage/provider.cpp 256b214b1d31b50fb1812227ae10a387a66e87e0 
  src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 
  src/tests/slave_tests.cpp 25cfd4730c3d77d1886745204b13ca3cb140620c 


Diff: https://reviews.apache.org/r/64400/diff/1/


Testing
-------

make check


Thanks,

Greg Mann


Re: Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64400/#review193090
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 7, 2017, 3:14 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64400/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2017, 3:14 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto 2ce71f4c3e97e89c226966c347c2817e2bab9c1b 
>   include/mesos/v1/resource_provider/resource_provider.proto 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb 
>   src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe 
>   src/resource_provider/state.proto ae30d1677a51fa837c19b47515761c30dae5b9d8 
>   src/resource_provider/storage/provider.cpp 256b214b1d31b50fb1812227ae10a387a66e87e0 
>   src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2 
>   src/tests/slave_tests.cpp 25cfd4730c3d77d1886745204b13ca3cb140620c 
> 
> 
> Diff: https://reviews.apache.org/r/64400/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64400/
-----------------------------------------------------------

(Updated Dec. 8, 2017, 7:19 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Repository: mesos


Description
-------

Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.


Diffs (updated)
-----

  include/mesos/resource_provider/resource_provider.proto d2b9c7902ab9ba81f240ae599ea8d9b28a413f9a 
  include/mesos/v1/resource_provider/resource_provider.proto 0c23e915f32dabfca0c6a420e303514117e6a6eb 
  src/messages/messages.proto 1a7096708adab8003a104911b290ecd3ed252e5d 
  src/resource_provider/manager.cpp e75d5289c51c326a31f22ea7db1941fe9310774c 
  src/resource_provider/state.proto ae30d1677a51fa837c19b47515761c30dae5b9d8 
  src/resource_provider/storage/provider.cpp a0294219f342eb9b934993394718d64ac8033223 
  src/tests/mesos.hpp 76fbd902042abe95ab4f7431b30989990e48817c 
  src/tests/slave_tests.cpp 66406204d73f75fb766f29361abafb6cfa6dd5a6 


Diff: https://reviews.apache.org/r/64400/diff/4/

Changes: https://reviews.apache.org/r/64400/diff/3-4/


Testing
-------

make check


Thanks,

Greg Mann


Re: Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64400/
-----------------------------------------------------------

(Updated Dec. 8, 2017, 7:11 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Repository: mesos


Description
-------

Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.


Diffs (updated)
-----

  include/mesos/resource_provider/resource_provider.proto d2b9c7902ab9ba81f240ae599ea8d9b28a413f9a 
  include/mesos/v1/resource_provider/resource_provider.proto 0c23e915f32dabfca0c6a420e303514117e6a6eb 
  src/resource_provider/manager.cpp e75d5289c51c326a31f22ea7db1941fe9310774c 
  src/resource_provider/state.proto ae30d1677a51fa837c19b47515761c30dae5b9d8 
  src/resource_provider/storage/provider.cpp a0294219f342eb9b934993394718d64ac8033223 
  src/tests/mesos.hpp 76fbd902042abe95ab4f7431b30989990e48817c 
  src/tests/slave_tests.cpp 66406204d73f75fb766f29361abafb6cfa6dd5a6 


Diff: https://reviews.apache.org/r/64400/diff/3/

Changes: https://reviews.apache.org/r/64400/diff/2-3/


Testing
-------

make check


Thanks,

Greg Mann


Re: Review Request 64400: Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64400/
-----------------------------------------------------------

(Updated Dec. 7, 2017, 10:23 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Changes
-------

Rebase.


Repository: mesos


Description
-------

Changed the resource provider OPERATION event to APPLY_OFFER_OPERATION.


Diffs (updated)
-----

  include/mesos/resource_provider/resource_provider.proto d2b9c7902ab9ba81f240ae599ea8d9b28a413f9a 
  include/mesos/v1/resource_provider/resource_provider.proto 0c23e915f32dabfca0c6a420e303514117e6a6eb 
  src/resource_provider/manager.cpp 2aee46e22958cc3a3ac87ceb5a77cb8f94c73054 
  src/resource_provider/state.proto ae30d1677a51fa837c19b47515761c30dae5b9d8 
  src/resource_provider/storage/provider.cpp a2794acda7187f78ed4246158da71cc26a7892c8 
  src/tests/mesos.hpp 53890d8b7123be02526c96cd62e0e754c25ef4be 
  src/tests/slave_tests.cpp 25cfd4730c3d77d1886745204b13ca3cb140620c 


Diff: https://reviews.apache.org/r/64400/diff/2/

Changes: https://reviews.apache.org/r/64400/diff/1-2/


Testing
-------

make check


Thanks,

Greg Mann