You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/24 12:51:22 UTC

[GitHub] [airflow] ashb commented on a change in pull request #7521: [AIRFLOW-6897] Simplify DagFileProcessorManager

ashb commented on a change in pull request #7521: [AIRFLOW-6897] Simplify DagFileProcessorManager
URL: https://github.com/apache/airflow/pull/7521#discussion_r383246546
 
 

 ##########
 File path: airflow/utils/dag_processing.py
 ##########
 @@ -569,7 +569,7 @@ def __init__(self,
         # Map from file path to the processor
         self._processors: Dict[str, AbstractDagFileProcessorProcess] = {}
 
-        self._heartbeat_count = 0
+        self._no_run = 0
 
 Review comment:
   ```suggestion
           self._num_run = 0
   ```
   
   Please? Seeing `_no_run` I expected it to be a boolean/flag variable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services