You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/04/25 20:36:43 UTC
Re: Review Request 46128: AMBARI-15724 Integrate Version Registration
in Select Stack Page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46128/
-----------------------------------------------------------
(Updated April 25, 2016, 6:36 p.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
Summary (updated)
-----------------
AMBARI-15724 Integrate Version Registration in Select Stack Page
Bugs: AMBARI-15724
https://issues.apache.org/jira/browse/AMBARI-15724
Repository: ambari
Description (updated)
-------
Implement New "Select Stack Page".
Should have two main options : use local repo & use public repo.
Diffs (updated)
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 5596a7f
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 3da088b
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js e95ebdb
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js fd3a8ba
ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css edf8524
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 8e9d3e2
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java a78af6e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java c9fa9a3
ambari-web/app/assets/data/wizard/stack/HDP_version_definitions.json PRE-CREATION
ambari-web/app/controllers/installer.js 73f9801
ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js a056d3b
ambari-web/app/controllers/main/service/add_controller.js 73abd59
ambari-web/app/controllers/wizard.js f242523
ambari-web/app/controllers/wizard/step1_controller.js c357bf4
ambari-web/app/controllers/wizard/step8_controller.js a5eb949
ambari-web/app/mappers/repository_version_mapper.js 67cfe64
ambari-web/app/mappers/stack_mapper.js 75245e0
ambari-web/app/messages.js 907d9ae
ambari-web/app/models/stack.js 0b1c9d2
ambari-web/app/models/stack_version/repository_version.js e02999f
ambari-web/app/routes/add_service_routes.js ad256f5
ambari-web/app/styles/application.less 890a43c
ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 35677ab
ambari-web/app/templates/main/admin/stack_upgrade/services.hbs a87c50c
ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs a9fc440
ambari-web/app/templates/wizard/step1.hbs ab9a0dd
ambari-web/app/templates/wizard/step4.hbs cc4c68f
ambari-web/app/utils/ajax/ajax.js 1cb70c5
ambari-web/app/utils/db.js 865839c
ambari-web/app/views/main/admin/stack_upgrade/services_view.js 8805c47
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 88bfec2
ambari-web/app/views/wizard/step1_view.js 452e676
ambari-web/test/controllers/installer_test.js 353129b
ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 00d7ce8
ambari-web/test/controllers/wizard/step8_test.js e93e001
ambari-web/test/mappers/stack_mapper_test.js 0bc0f3c
ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js 9a42c42
ambari-web/test/views/wizard/step1_view_test.js 0dacad8
Diff: https://reviews.apache.org/r/46128/diff/
Testing (updated)
-------
Add and modified test cases.
ambari-web:
27544 tests complete (24 seconds)
154 tests pending
ambari-admin:
Executed 64 of 64 SUCCESS (0.086 secs / 0.308 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 46128: AMBARI-15724 Integrate Version Registration
in Select Stack Page
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46128/#review130486
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On April 25, 2016, 6:36 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46128/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 6:36 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15724
> https://issues.apache.org/jira/browse/AMBARI-15724
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Implement New "Select Stack Page".
> Should have two main options : use local repo & use public repo.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 5596a7f
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 3da088b
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js e95ebdb
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js fd3a8ba
> ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css edf8524
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 8e9d3e2
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java a78af6e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java c9fa9a3
> ambari-web/app/assets/data/wizard/stack/HDP_version_definitions.json PRE-CREATION
> ambari-web/app/controllers/installer.js 73f9801
> ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js a056d3b
> ambari-web/app/controllers/main/service/add_controller.js 73abd59
> ambari-web/app/controllers/wizard.js f242523
> ambari-web/app/controllers/wizard/step1_controller.js c357bf4
> ambari-web/app/controllers/wizard/step8_controller.js a5eb949
> ambari-web/app/mappers/repository_version_mapper.js 67cfe64
> ambari-web/app/mappers/stack_mapper.js 75245e0
> ambari-web/app/messages.js 907d9ae
> ambari-web/app/models/stack.js 0b1c9d2
> ambari-web/app/models/stack_version/repository_version.js e02999f
> ambari-web/app/routes/add_service_routes.js ad256f5
> ambari-web/app/styles/application.less 890a43c
> ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 35677ab
> ambari-web/app/templates/main/admin/stack_upgrade/services.hbs a87c50c
> ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs a9fc440
> ambari-web/app/templates/wizard/step1.hbs ab9a0dd
> ambari-web/app/templates/wizard/step4.hbs cc4c68f
> ambari-web/app/utils/ajax/ajax.js 1cb70c5
> ambari-web/app/utils/db.js 865839c
> ambari-web/app/views/main/admin/stack_upgrade/services_view.js 8805c47
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 88bfec2
> ambari-web/app/views/wizard/step1_view.js 452e676
> ambari-web/test/controllers/installer_test.js 353129b
> ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 00d7ce8
> ambari-web/test/controllers/wizard/step8_test.js e93e001
> ambari-web/test/mappers/stack_mapper_test.js 0bc0f3c
> ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js 9a42c42
> ambari-web/test/views/wizard/step1_view_test.js 0dacad8
>
> Diff: https://reviews.apache.org/r/46128/diff/
>
>
> Testing
> -------
>
> Add and modified test cases.
> ambari-web:
> 27544 tests complete (24 seconds)
> 154 tests pending
> ambari-admin:
> Executed 64 of 64 SUCCESS (0.086 secs / 0.308 secs)
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 46128: AMBARI-15724 Integrate Version Registration
in Select Stack Page
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46128/#review131212
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On April 26, 2016, 8:27 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46128/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 8:27 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15724
> https://issues.apache.org/jira/browse/AMBARI-15724
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Implement New "Select Stack Page".
> Should have two main options : use local repo & use public repo.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 5596a7f
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 3da088b
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 3e475d9
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js fd3a8ba
> ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css b55d89c
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 8e9d3e2
> ambari-web/app/assets/data/wizard/stack/HDP_version_definitions.json PRE-CREATION
> ambari-web/app/controllers/installer.js 73f9801
> ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js a056d3b
> ambari-web/app/controllers/main/service/add_controller.js 73abd59
> ambari-web/app/controllers/wizard.js 52fb241
> ambari-web/app/controllers/wizard/step1_controller.js c357bf4
> ambari-web/app/controllers/wizard/step8_controller.js a5eb949
> ambari-web/app/mappers/repository_version_mapper.js 67cfe64
> ambari-web/app/mappers/stack_mapper.js 75245e0
> ambari-web/app/messages.js 8c8b9e5
> ambari-web/app/models/stack.js 0b1c9d2
> ambari-web/app/models/stack_version/repository_version.js e02999f
> ambari-web/app/routes/add_service_routes.js ad256f5
> ambari-web/app/styles/application.less 8a34462
> ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 35677ab
> ambari-web/app/templates/main/admin/stack_upgrade/services.hbs a87c50c
> ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs a9fc440
> ambari-web/app/templates/wizard/step1.hbs ab9a0dd
> ambari-web/app/templates/wizard/step4.hbs cc4c68f
> ambari-web/app/utils/ajax/ajax.js 1cb70c5
> ambari-web/app/utils/db.js 865839c
> ambari-web/app/views/main/admin/stack_upgrade/services_view.js 8805c47
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 88bfec2
> ambari-web/app/views/wizard/step1_view.js 452e676
> ambari-web/test/controllers/installer_test.js 353129b
> ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 00d7ce8
> ambari-web/test/controllers/wizard/step8_test.js e93e001
> ambari-web/test/mappers/stack_mapper_test.js 0bc0f3c
> ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js 9a42c42
> ambari-web/test/views/wizard/step1_view_test.js 0dacad8
>
> Diff: https://reviews.apache.org/r/46128/diff/
>
>
> Testing
> -------
>
> Add and modified test cases.
> ambari-web:
> 27544 tests complete (24 seconds)
> 154 tests pending
> ambari-admin:
> Executed 64 of 64 SUCCESS (0.086 secs / 0.308 secs)
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 46128: AMBARI-15724 Integrate Version Registration
in Select Stack Page
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46128/
-----------------------------------------------------------
(Updated April 26, 2016, 8:27 p.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15724
https://issues.apache.org/jira/browse/AMBARI-15724
Repository: ambari
Description
-------
Implement New "Select Stack Page".
Should have two main options : use local repo & use public repo.
Diffs (updated)
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 5596a7f
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 3da088b
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 3e475d9
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js fd3a8ba
ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css b55d89c
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 8e9d3e2
ambari-web/app/assets/data/wizard/stack/HDP_version_definitions.json PRE-CREATION
ambari-web/app/controllers/installer.js 73f9801
ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js a056d3b
ambari-web/app/controllers/main/service/add_controller.js 73abd59
ambari-web/app/controllers/wizard.js 52fb241
ambari-web/app/controllers/wizard/step1_controller.js c357bf4
ambari-web/app/controllers/wizard/step8_controller.js a5eb949
ambari-web/app/mappers/repository_version_mapper.js 67cfe64
ambari-web/app/mappers/stack_mapper.js 75245e0
ambari-web/app/messages.js 8c8b9e5
ambari-web/app/models/stack.js 0b1c9d2
ambari-web/app/models/stack_version/repository_version.js e02999f
ambari-web/app/routes/add_service_routes.js ad256f5
ambari-web/app/styles/application.less 8a34462
ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 35677ab
ambari-web/app/templates/main/admin/stack_upgrade/services.hbs a87c50c
ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs a9fc440
ambari-web/app/templates/wizard/step1.hbs ab9a0dd
ambari-web/app/templates/wizard/step4.hbs cc4c68f
ambari-web/app/utils/ajax/ajax.js 1cb70c5
ambari-web/app/utils/db.js 865839c
ambari-web/app/views/main/admin/stack_upgrade/services_view.js 8805c47
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 88bfec2
ambari-web/app/views/wizard/step1_view.js 452e676
ambari-web/test/controllers/installer_test.js 353129b
ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 00d7ce8
ambari-web/test/controllers/wizard/step8_test.js e93e001
ambari-web/test/mappers/stack_mapper_test.js 0bc0f3c
ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js 9a42c42
ambari-web/test/views/wizard/step1_view_test.js 0dacad8
Diff: https://reviews.apache.org/r/46128/diff/
Testing
-------
Add and modified test cases.
ambari-web:
27544 tests complete (24 seconds)
154 tests pending
ambari-admin:
Executed 64 of 64 SUCCESS (0.086 secs / 0.308 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang