You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Angus-Slalom <gi...@git.apache.org> on 2017/08/24 20:39:24 UTC
[GitHub] storm pull request #2294: STORM-2517 add interface for Writer, make Abstract...
GitHub user Angus-Slalom opened a pull request:
https://github.com/apache/storm/pull/2294
STORM-2517 add interface for Writer, make AbstractHDFSWriter properti…
…es protected
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Angus-Slalom/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2294
----
commit d3ece270fbcace79195a4217731c3f82bcf2b360
Author: Angus Helm <an...@slalom.com>
Date: 2017-08-24T20:34:19Z
STORM-2517 add interface for Writer, make AbstractHDFSWriter properties protected
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2294: STORM-2517 add interface for Writer, make AbstractHDFSWri...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2294
@Angus-Slalom there are some checkstyle violations here, which is why the build is failing. Other then that it looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2294: STORM-2517 add interface for Writer, make Abstract...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2294: STORM-2517 add interface for Writer, make AbstractHDFSWri...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2294
@Angus-Slalom actually because these are all just white space changes I can do it myself when I check it in.
Let me run the tests all the way through to be sure it looks good then I'll pull it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2294: STORM-2517 add interface for Writer, make AbstractHDFSWri...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2294
```
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/Writer.java
18: 'package' should be separated from previous statement.
23: Wrong lexicographical order for 'java.io.IOException' import. Should be before 'org.apache.storm.tuple.Tuple'.
```
are the two issues associated with the new file you added. Then there is just one more added in, but because it is changes to existing files it is hard to tell, so it is simplest to just pick one or two other issues to "fix" too.
```
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/common/AbstractHDFSWriter.java
18: 'package' should be separated from previous statement.
25: Wrong lexicographical order for 'java.io.IOException' import. Should be before 'org.apache.storm.tuple.Tuple'.
27: Abbreviation in name 'AbstractHDFSWriter' must contain no more than '2' consecutive capital letters.
27: 'public' modifier out of order with the JLS suggestions.
31: 'protected' modifier out of order with the JLS suggestions.
32: 'protected' modifier out of order with the JLS suggestions.
34: Missing a Javadoc comment.
40: Missing a Javadoc comment.
40: 'public' modifier out of order with the JLS suggestions.
47: 'public' modifier out of order with the JLS suggestions.
51: 'public' modifier out of order with the JLS suggestions.
63: 'protected' modifier out of order with the JLS suggestions.
65: 'protected' modifier out of order with the JLS suggestions.
67: 'protected' modifier out of order with the JLS suggestions.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2294: STORM-2517 add interface for Writer, make AbstractHDFSWri...
Posted by Angus-Slalom <gi...@git.apache.org>.
Github user Angus-Slalom commented on the issue:
https://github.com/apache/storm/pull/2294
Created for pull request https://github.com/apache/storm/pull/2157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---