You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/11/14 01:01:13 UTC

[GitHub] [hbase] infraio commented on a change in pull request #813: HBASE-23253 Rewrite rsgroup related UTs with the new methods introduc…

infraio commented on a change in pull request #813: HBASE-23253 Rewrite rsgroup related UTs with the new methods introduc…
URL: https://github.com/apache/hbase/pull/813#discussion_r346081825
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
 ##########
 @@ -2315,15 +2315,15 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
    * @param servers set of servers to remove
    * @throws IOException if a remote or network exception occurs
    */
-  void removeRSGroup(Set<Address> servers) throws IOException;
+  void removeServers(Set<Address> servers) throws IOException;
 
 Review comment:
   removeServersFromRSGroup? And no need rsgroup as the parameter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services