You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2017/05/30 23:26:05 UTC

mesos git commit: Resolved a TODO that depended on a newer version of gtest.

Repository: mesos
Updated Branches:
  refs/heads/master 80f13bfd0 -> c61e592d7


Resolved a TODO that depended on a newer version of gtest.

Review: https://reviews.apache.org/r/59581/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/c61e592d
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/c61e592d
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/c61e592d

Branch: refs/heads/master
Commit: c61e592d7b773e3d939fb1165480f735d14bb18d
Parents: 80f13bf
Author: Gastón Kleiman <ga...@mesosphere.io>
Authored: Tue May 30 16:25:52 2017 -0700
Committer: Vinod Kone <vi...@gmail.com>
Committed: Tue May 30 16:25:52 2017 -0700

----------------------------------------------------------------------
 src/tests/default_executor_tests.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/c61e592d/src/tests/default_executor_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/default_executor_tests.cpp b/src/tests/default_executor_tests.cpp
index d074c1a..a76ece5 100644
--- a/src/tests/default_executor_tests.cpp
+++ b/src/tests/default_executor_tests.cpp
@@ -101,19 +101,15 @@ protected:
 
 
 // These tests are parameterized by the containerizers enabled on the agent.
-//
-// TODO(gkleiman): The version of gtest currently used by Mesos doesn't support
-// passing `::testing::Values` a single value. Update these calls once we
-// upgrade to a newer version.
 INSTANTIATE_TEST_CASE_P(
     MesosContainerizer,
     DefaultExecutorTest,
-    ::testing::ValuesIn(vector<string>({"mesos"})));
+    ::testing::Values("mesos"));
 
 INSTANTIATE_TEST_CASE_P(
     ROOT_DOCKER_DockerAndMesosContainerizers,
     DefaultExecutorTest,
-    ::testing::ValuesIn(vector<string>({"docker,mesos"})));
+    ::testing::Values("docker,mesos"));
 
 
 // This test verifies that the default executor can launch a task group.