[jira] [Updated] (HADOOP-13238) pid handling is failing on secure datanode

["Andras Bokor (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andras Bokor updated HADOOP-13238:
----------------------------------
    Attachment: HADOOP-13238.01.patch

[~aw]

The root cause here is that JSVC will delete the pid file which was passed to it with {{-pidfile}} option. So after stop {{cat}} will fail.
Honestly, I feel HADOOP-12364 solves a bug in an external monitoring tool rather than in Hadoop. That is a pretty rare case (I cannot even imagine how can it happen) so I think here it is enough to check that whether the pid file exists or not. If not that means JSVC deleted the file so we do not need to do check and delete.
In addition the error message shows up twice because either {{hadoop_stop_daemon.bats}} or {{hadoop_stop_secure_daemon.bats}} do the same check and deletes the same pid file. The second one can be removed from the code.

After my patch the test still passes. {{adoop_stop_daemon.bats}} and {{adoop_stop_secure_daemon.bats}} do the same test so the first seems unnecessary.
{code}abokor$ bats hadoop_stop_secure_daemon.bats
 ✓ hadoop_stop_secure_daemon

1 test, 0 failures{code}

> pid handling is failing on secure datanode
> ------------------------------------------
>
>                 Key: HADOOP-13238
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13238
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts, security
>            Reporter: Allen Wittenauer
>            Assignee: Andras Bokor
>         Attachments: HADOOP-13238.01.patch
>
>
> {code}
> hdfs --daemon stop datanode
> cat: /home/hadoop/H/pids/hadoop-hdfs-root-datanode.pid: No such file or directory
> WARNING: pid has changed for datanode, skip deleting pid file
> cat: /home/hadoop/H/pids/hadoop-hdfs-root-datanode.pid: No such file or directory
> WARNING: daemon pid has changed for datanode, skip deleting daemon pid file
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org