You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/03/11 02:07:20 UTC

[GitHub] [gobblin] ZihanLi58 commented on a change in pull request #3242: [GOBBLIN-1408] Uses empty password on local test runs

ZihanLi58 commented on a change in pull request #3242:
URL: https://github.com/apache/gobblin/pull/3242#discussion_r592014322



##########
File path: gobblin-metastore/src/test/java/org/apache/gobblin/metastore/testing/TestMetastoreDatabaseServer.java
##########
@@ -152,10 +152,12 @@ private MySqlJdbcUrl getBaseJdbcUrl() throws URISyntaxException {
   }
 
   private MySqlJdbcUrl getInformationSchemaJdbcUrl() throws URISyntaxException {
+    // embedded mysql has an empty password by default
+    String password =  this.embeddedMysqlEnabled ? "" : ROOT_PASSWORD;

Review comment:
       I see EMBEDDED_MYSQL_ENABLED_FULL_KEY by default is set to be true, just curious when it's running in CI, how the config will be set as false?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org