You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Varun Thacker (JIRA)" <ji...@apache.org> on 2018/09/07 22:04:00 UTC
[jira] [Commented] (SOLR-9786) Defer creation of clauses in parser,
optionally delegate groups to FieldType.getSetQuery
[ https://issues.apache.org/jira/browse/SOLR-9786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607716#comment-16607716 ]
Varun Thacker commented on SOLR-9786:
-------------------------------------
I was trying to find this Jira to see what version was this fixed in. Then I got curious to see how it's implemented and I had a question about this one line
{code:java}
public static final int TERMS_QUERY_THRESHOLD = 16; // @lucene.internal Set to a low value temporarily for better test coverage{code}
Is 16 still supposed to be the threshold ? I don't have a sense as to what's a good/bad number but thought I'd point it out anyways
> Defer creation of clauses in parser, optionally delegate groups to FieldType.getSetQuery
> ----------------------------------------------------------------------------------------
>
> Key: SOLR-9786
> URL: https://issues.apache.org/jira/browse/SOLR-9786
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Major
> Labels: numeric-tries-to-points
> Fix For: 6.4, 7.0
>
> Attachments: SOLR-9786.patch, SOLR-9786.patch
>
>
> Solr's query parser currently creates a query for each clause it sees independently. This is no longer desirable, since if we are creating a filter (non-scoring query), we can use a TermsQuery.
> PointFields SOLR-8396 also need to see a set of values together to efficiently create a set query.
> This issue:
> - adds context for the parser to know when it's parsing a query for matching only (that's only for the TermsQuery... I assume Points would always use a set query when passed multiple values)
> - defers creation of real Query objects for simple term queries in a boolean query
> - aggregates those values by field at the end to be passed to a new FieldType.getSetQuery method
> - FieldType.getSetQuery base implementation uses TermsQuery for indexed fields
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org