You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2015/02/19 21:26:33 UTC
[Bug 57605] New: When there is an error loading Test Plan,
SaveService.loadTree returns null leading to NPE in callers
https://bz.apache.org/bugzilla/show_bug.cgi?id=57605
Bug ID: 57605
Summary: When there is an error loading Test Plan,
SaveService.loadTree returns null leading to NPE in
callers
Product: JMeter
Version: 2.12
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: p.mouawad@ubik-ingenierie.com
Currently whenever JMeter Test plan fails to load :
- Missing jars
- Wrong version
You end up getting NullPointerException which does not contain any clue of the
initial problem:
2015/02/19 15:40:23 ERROR - jmeter.JMeter: Error in NonGUIDriver
java.lang.NullPointerException
at
org.apache.jmeter.gui.tree.JMeterTreeModel.addSubTree(JMeterTreeModel.java:110)
at org.apache.jmeter.JMeter.runNonGui(JMeter.java:763)
at org.apache.jmeter.JMeter.startNonGui(JMeter.java:741)
at org.apache.jmeter.JMeter.start(JMeter.java:399)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.jmeter.NewDriver.main(NewDriver.java:264)
1/ I propose to instead tbrow new IllegalArgumentException("Error loading jmx
file from :"+f+", check log file");
2/ I also propose to change parameter to File instead of Reader to be able to
clarify message
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57605] When there is an error loading Test Plan,
SaveService.loadTree returns null leading to NPE in callers
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57605
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #2 from Sebb <se...@apache.org> ---
(In reply to Philippe Mouawad from comment #0)
>
> 2/ I also propose to change parameter to File instead of Reader to be able
> to clarify message
This may break 3rd party code.
We cannot just change the public API signature without warning.
The original API needs to be retained, possibly with a a warning that it is
deprecated.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57605] When there is an error loading Test Plan,
SaveService.loadTree returns null leading to NPE in callers
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57605
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Mon Feb 23 20:18:45 2015
New Revision: 1661763
URL: http://svn.apache.org/r1661763
Log:
[Bug 57605] When there is an error loading Test Plan, SaveService.loadTree
returns null leading to NPE in callers
Retain backward compatibility as per sebb note
Bugzilla Id: 57605
Modified:
jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57605] When there is an error loading Test Plan,
SaveService.loadTree returns null leading to NPE in callers
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57605
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
CC| |p.mouawad@ubik-ingenierie.c
| |om
--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Thu Feb 19 21:30:55 2015
New Revision: 1661007
URL: http://svn.apache.org/r1661007
Log:
Bug 57605 - When there is an error loading Test Plan, SaveService.loadTree
returns null leading to NPE in callers
Bugzilla Id: 57605
Modified:
jmeter/trunk/src/components/org/apache/jmeter/control/IncludeController.java
jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Load.java
jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
jmeter/trunk/test/src/org/apache/jmeter/gui/action/TestLoad.java
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestAnchorModifier.java
jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.