[GitHub] Ryanthegiantlion commented on issue #3844: Severe regression: Slices with calculated time(?) columns stopped working, due to quoting of the column expression

[GitBox <gi...@apache.org>]

Ryanthegiantlion commented on issue #3844: Severe regression: Slices with calculated time(?) columns stopped working, due to quoting of the column expression
URL: https://github.com/apache/incubator-superset/issues/3844#issuecomment-343810766
 
 
   @rumbin It seems a problem that at query time we cannot tell if a column is indeed a database column or a database expression. Unfortunately I am not familiar with sql alchemy to know how to handle this offhand. There is a meta data prop on the baseclass: https://github.com/apache/incubator-superset/blob/500455fc72dc58f9c0bd32d2b3b4da9a915bfb8c/superset/db_engine_specs.py#L72, so perhaps that can be used.
   
   I will have a go at creating a PR that can handle both cases this week. If a fix cannot be provided it probably makes sense to revert the change. There is a workaround for #3208 - just create a view with properties cased correctly. It is a tedious workaround though, especially if every timestamp in the DB is cased 'createdAt', so it would be nice to keep the fix . . .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services