You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Pete Robbins (JIRA)" <ji...@apache.org> on 2016/03/25 08:46:25 UTC

[jira] [Commented] (SPARK-14151) Propose to expose Metrics Sink and Source interface

    [ https://issues.apache.org/jira/browse/SPARK-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211560#comment-15211560 ] 

Pete Robbins commented on SPARK-14151:
--------------------------------------

In addition the constructor used by MetricsSystem for Sinks passes the SecurityManager which is also marked as private[spark]. Currently only the MetricsServlet sink uses this.

We could either a) remove private[spark] from SecurityManager or b) add additional logic in MetricsSystem to look for a Sink constructor which does not have the SecurityManager as a parameter if the one with SecurityManager is not found

> Propose to expose Metrics Sink and Source interface
> ---------------------------------------------------
>
>                 Key: SPARK-14151
>                 URL: https://issues.apache.org/jira/browse/SPARK-14151
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>            Reporter: Saisai Shao
>            Priority: Minor
>
> MetricsSystem is designed for plug-in different sources and sinks, user could write their own sources and sinks and configured through metrics.properties, MetricsSystem will register it through reflection. But current Source and Sink interface is private, which means user cannot create their own sources and sinks unless using the same package.
> So here propose to expose source and sink interface, this will let user build and maintain their own source and sink, alleviate the maintenance overhead of spark codebase. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org