You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/22 13:30:17 UTC
[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #312: [ISSUE #308]add default topic check to filter warning logs.
ShannonDing opened a new pull request #312:
URL: https://github.com/apache/rocketmq-client-cpp/pull/312
close #308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] ifplusor commented on a change in pull request #312: [ISSUE #308]add default topic check to filter warning logs.
Posted by GitBox <gi...@apache.org>.
ifplusor commented on a change in pull request #312:
URL: https://github.com/apache/rocketmq-client-cpp/pull/312#discussion_r429706535
##########
File path: src/MQClientAPIImpl.cpp
##########
@@ -325,7 +325,9 @@ TopicRouteData* MQClientAPIImpl::getTopicRouteInfoFromNameServer(const string& t
}
}
case TOPIC_NOT_EXIST: {
- LOG_WARN("Get topic[%s] route failed [TOPIC_NOT_EXIST].", topic.c_str());
+ if (DEFAULT_TOPIC.compare(topic) != 0) {
Review comment:
Why not use ```topic != DEFAULT_TOPIC``` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] codecov-commenter commented on pull request #312: [ISSUE #308]add default topic check to filter warning logs.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #312:
URL: https://github.com/apache/rocketmq-client-cpp/pull/312#issuecomment-632703779
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/312?src=pr&el=h1) Report
> Merging [#312](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/312?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/6f5261595a1245d2a890a674a062d3b398f0c541&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/312?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 59.01% 59.00% -0.01%
==========================================
Files 205 205
Lines 12985 12987 +2
==========================================
Hits 7663 7663
- Misses 5322 5324 +2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/312?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/MQClientAPIImpl.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/312/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50QVBJSW1wbC5jcHA=) | `24.94% <0.00%> (-0.11%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/312?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/312?src=pr&el=footer). Last update [6f52615...9fd47a2](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/312?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] RongtongJin merged pull request #312: [ISSUE #308]add default topic check to filter warning logs.
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #312:
URL: https://github.com/apache/rocketmq-client-cpp/pull/312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org