You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "samueleresca (via GitHub)" <gi...@apache.org> on 2023/12/22 16:02:54 UTC
[PR] Removing CDN assets from theme. [incubator-pekko-sbt-paradox]
samueleresca opened a new pull request, #86:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/86
Related to https://github.com/apache/incubator-pekko-sbt-paradox/issues/84:
- Removed static assets from theme as will be moved to `incubator-pekko-site`
- Keep relative URLs (i.e.: `assets/stylesheets/pekko-theme.css`) as they are automatically resolved as `https://hostname/assets/stylesheets/pekko-theme.css`
Required changes: https://github.com/apache/incubator-pekko-site/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Removing CDN assets from theme. [incubator-pekko-sbt-paradox]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #86:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/86#issuecomment-1868531722
> One thing is that we'll make testing doc changes to repos like https://github.com/apache/incubator-pekko harder.
>
> Today, if you run `sbt paradoxBrowse`, it will build the docs into target/paradox/main/site and you can load up the index.html page from there and the CSS, etc. will be found. In theory, users could copy the missing files into target/paradox/main/site themselves or we could script something.
>
> In the end, it might be easier if we don't rely on relative paths and hardcode that we can get the static files from explicit URLs. We could make the hostname of these URLs configurable. Default to `https://pekko.apache.org` but users could set `https://pekko.staged.apache.org`.
@pjfanning
I have added the `assets.hostname` variable for handling the hostname. Default is configured to `https://pekko.apache.org`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Removing CDN assets from theme. [incubator-pekko-sbt-paradox]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca merged PR #86:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Removing CDN assets from theme. [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #86:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/86#issuecomment-1867992884
One thing is that we'll make testing doc changes to repos like https://github.com/apache/incubator-pekko harder.
Today, if you run `sbt paradoxBrowse`, it will build the docs and into target/paradox/main/site and you can load up the index.html page there and the CSS etc will be found. In theory, users could copy the missing files into target/paradox/main/site themselves or we could script something.
In the end, it might be easier if we don't rely on relative paths and hardcode that we can get the static files from explicit URLs. We could make the hostname of these URLs configurable. Default to `https://pekko.apache.org` but users could set `https://pekko.staged.apache.org`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org