[GitHub] spark pull request: [SPARK-8676][SQL]Lazy start event logger in sq...

[andrewor14 <gi...@git.apache.org>]

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8048#discussion_r38480560
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -185,9 +194,23 @@ private[spark] class EventLoggingListener(
       }
     
       override def onApplicationStart(event: SparkListenerApplicationStart): Unit = {
    +    if (!sparkConf.get("spark.app.name").startsWith("SparkSQL::")) {
    +      start()
    +      started.compareAndSet(false, true)
    +    }
         logEvent(event, flushLogger = true)
       }
     
    +  def onSQLApplicationStart(): Unit = {
    --- End diff --
    
    we shouldn't have SQL specific things in core


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org