You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "IOhacker (via GitHub)" <gi...@apache.org> on 2023/01/23 22:32:27 UTC
[GitHub] [fineract] IOhacker opened a new pull request, #2917: FINERACT-1864 Fix the creation of Fixed Deposit Product
IOhacker opened a new pull request, #2917:
URL: https://github.com/apache/fineract/pull/2917
## Description
Fix the creation of Fixed Deposit Product because Range Validation for Slabs were incorrect.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [X] Create/update unit or integration tests for verifying the changes made.
- [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2917: FINERACT-1864 Fix the creation of Fixed Deposit Product
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #2917:
URL: https://github.com/apache/fineract/pull/2917#issuecomment-1510978719
Closing as per the comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2917: FINERACT-1864 Fix the creation of Fixed Deposit Product
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2917:
URL: https://github.com/apache/fineract/pull/2917#issuecomment-1441036149
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2917: FINERACT-1864 Fix the creation of Fixed Deposit Product
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #2917:
URL: https://github.com/apache/fineract/pull/2917#issuecomment-1467643301
@IOhacker is this still being worked on/needed? Seems a bit stale... if not then I'd rather close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics closed pull request #2917: FINERACT-1864 Fix the creation of Fixed Deposit Product
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics closed pull request #2917: FINERACT-1864 Fix the creation of Fixed Deposit Product
URL: https://github.com/apache/fineract/pull/2917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2917: FINERACT-1864 Fix the creation of Fixed Deposit Product
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2917:
URL: https://github.com/apache/fineract/pull/2917#issuecomment-1509413996
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #2917: FINERACT-1864 Fix the creation of Fixed Deposit Product
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #2917:
URL: https://github.com/apache/fineract/pull/2917#issuecomment-1468331872
No time to continue with the requirements made. You can close it.
El mar, 14 mar 2023 a las 2:39, Aleksandar Vidakovic (<
***@***.***>) escribió:
> @IOhacker <https://github.com/IOhacker> is this still being worked
> on/needed? Seems a bit stale... if not then I'd rather close it.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/2917#issuecomment-1467643301>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZATHD7YRQEKULALLOXTW4AVCVANCNFSM6AAAAAAUEML7QE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org