You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/02 09:00:30 UTC
[GitHub] [apisix] diaosj opened a new pull request #2351: doc: update router variable examlpe (#2298)
diaosj opened a new pull request #2351:
URL: https://github.com/apache/apisix/pull/2351
### What this PR does / why we need it:
Update the `router-radixtree` document.
The former router example in this document use "==" as the default operator, which is not the current behavior.
This PR modifies the example and keeps it consistent with the `admin-api` document.
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2351: doc: update router variable example (#2298)
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2351:
URL: https://github.com/apache/apisix/pull/2351#discussion_r499111885
##########
File path: doc/router-radixtree.md
##########
@@ -78,9 +78,11 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f
{
"uri": "/index.html",
"vars": [
- ["http_host", "iresty.com"],
- ["cookie__device_id", "a66f0cdc4ba2df8c096f74c9110163a9"],
- ["arg_name", "jack"]
+ ["http_host", "==", "iresty.com"],
+ ["cookie__device_id", "==", "a66f0cdc4ba2df8c096f74c9110163a9"],
Review comment:
in order to swprate keyword and custom namre?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #2351: doc: update router variable example (#2298)
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2351:
URL: https://github.com/apache/apisix/pull/2351#discussion_r499113274
##########
File path: doc/router-radixtree.md
##########
@@ -78,9 +78,11 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f
{
"uri": "/index.html",
"vars": [
- ["http_host", "iresty.com"],
- ["cookie__device_id", "a66f0cdc4ba2df8c096f74c9110163a9"],
- ["arg_name", "jack"]
+ ["http_host", "==", "iresty.com"],
+ ["cookie__device_id", "==", "a66f0cdc4ba2df8c096f74c9110163a9"],
Review comment:
it's a typo: http://nginx.org/en/docs/http/ngx_http_core_module.html#var_cookie_
only one `_`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #2351: doc: update router variable example (#2298)
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2351:
URL: https://github.com/apache/apisix/pull/2351#discussion_r499112970
##########
File path: doc/router-radixtree.md
##########
@@ -78,9 +78,11 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f
{
"uri": "/index.html",
"vars": [
- ["http_host", "iresty.com"],
- ["cookie__device_id", "a66f0cdc4ba2df8c096f74c9110163a9"],
- ["arg_name", "jack"]
+ ["http_host", "==", "iresty.com"],
+ ["cookie__device_id", "==", "a66f0cdc4ba2df8c096f74c9110163a9"],
Review comment:
I am not sure about this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #2351: doc: update router variable example (#2298)
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2351:
URL: https://github.com/apache/apisix/pull/2351#discussion_r499101678
##########
File path: doc/router-radixtree.md
##########
@@ -78,9 +78,11 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f
{
"uri": "/index.html",
"vars": [
- ["http_host", "iresty.com"],
- ["cookie__device_id", "a66f0cdc4ba2df8c096f74c9110163a9"],
- ["arg_name", "jack"]
+ ["http_host", "==", "iresty.com"],
+ ["cookie__device_id", "==", "a66f0cdc4ba2df8c096f74c9110163a9"],
Review comment:
Two _?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2351: doc: update router variable example (#2298)
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2351:
URL: https://github.com/apache/apisix/pull/2351#discussion_r499111885
##########
File path: doc/router-radixtree.md
##########
@@ -78,9 +78,11 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f
{
"uri": "/index.html",
"vars": [
- ["http_host", "iresty.com"],
- ["cookie__device_id", "a66f0cdc4ba2df8c096f74c9110163a9"],
- ["arg_name", "jack"]
+ ["http_host", "==", "iresty.com"],
+ ["cookie__device_id", "==", "a66f0cdc4ba2df8c096f74c9110163a9"],
Review comment:
in order to seprate keyword and custom name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2351: doc: update router variable example (#2298)
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2351:
URL: https://github.com/apache/apisix/pull/2351#discussion_r499111885
##########
File path: doc/router-radixtree.md
##########
@@ -78,9 +78,11 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f
{
"uri": "/index.html",
"vars": [
- ["http_host", "iresty.com"],
- ["cookie__device_id", "a66f0cdc4ba2df8c096f74c9110163a9"],
- ["arg_name", "jack"]
+ ["http_host", "==", "iresty.com"],
+ ["cookie__device_id", "==", "a66f0cdc4ba2df8c096f74c9110163a9"],
Review comment:
in order to swprate keyword and custom name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #2351: doc: update router variable example (#2298)
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2351:
URL: https://github.com/apache/apisix/pull/2351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org