You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/09/18 05:28:50 UTC
[GitHub] [spark] amaliujia opened a new pull request, #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
amaliujia opened a new pull request, #42971:
URL: https://github.com/apache/spark/pull/42971
….
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
`simplifyPlanForCollectedMetrics ` still could need to handle non alias-only project case where the project contains a mixed of aliases and attributes. In such case `simplifyPlanForCollectedMetrics` should also drop the extra project for the plan check when it contains CollectedMetrics.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Improve `simplifyPlanForCollectedMetrics` so it handles more plan pattern.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
NO
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1329419904
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala:
##########
@@ -1410,6 +1410,21 @@ class AnalysisSuite extends AnalysisTest with Matchers {
assertAnalysisSuccess(finalPlan)
}
+ test("Remove extra project as long as all attributes are semantically the same") {
+ val analyzer = getAnalyzer
+ val inner = Project(
+ Seq(
+ Alias(testRelation2.output(0), "a")(),
+ testRelation2.output(1),
+ Alias(testRelation2.output(2), "c")(),
+ testRelation2.output(3),
+ testRelation2.output(4),
+ ),
+ testRelation2)
+ val actual_plan = analyzer.simplifyPlanForCollectedMetrics(inner)
Review Comment:
note: now we only call `simplifyPlanForCollectedMetrics` with canonicalized plan. We should match it in the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1329105808
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The attribute id becomes the
// ordinal of this attribute in the child outputs. So an alias-only Project means the
// the id of the aliased attribute is the same as its index in the project list.
attr.exprId.id == index
case _ => false
Review Comment:
Interesting, the above didn't work I believe. Let me take a closer look by debugger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #42971:
URL: https://github.com/apache/spark/pull/42971#issuecomment-1727363616
The failed streaming test is unrelated, I'm merging it to master/3.5, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1328287604
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The attribute id becomes the
// ordinal of this attribute in the child outputs. So an alias-only Project means the
// the id of the aliased attribute is the same as its index in the project list.
attr.exprId.id == index
case _ => false
Review Comment:
It is Surprising for me to find that `Alias` is an expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1328287604
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The attribute id becomes the
// ordinal of this attribute in the child outputs. So an alias-only Project means the
// the id of the aliased attribute is the same as its index in the project list.
attr.exprId.id == index
case _ => false
Review Comment:
It is surprising for me to find that `Alias` is an expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1329298286
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The attribute id becomes the
// ordinal of this attribute in the child outputs. So an alias-only Project means the
// the id of the aliased attribute is the same as its index in the project list.
attr.exprId.id == index
case _ => false
Review Comment:
I am not sure how the existing behaves, but in my example I check the case where the expr.id is 1 but the index is 0. So `assignExprIdOnly` is not true.
<img width="762" alt="Screenshot 2023-09-18 at 2 19 49 PM" src="https://github.com/apache/spark/assets/1938382/e6850683-9557-4382-b203-be124c50606a">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1328261941
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The attribute id becomes the
// ordinal of this attribute in the child outputs. So an alias-only Project means the
// the id of the aliased attribute is the same as its index in the project list.
attr.exprId.id == index
case _ => false
Review Comment:
I think we just need to add one more case match here
```
// Both Attribute has been canonicalized to use index as the attr id, so `semanticEquals` still works here.
case (left: Attribute, right: Attribute) => left.semanticEquals(right)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
URL: https://github.com/apache/spark/pull/42971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #42971:
URL: https://github.com/apache/spark/pull/42971#issuecomment-1722776811
@cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1329105808
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The attribute id becomes the
// ordinal of this attribute in the child outputs. So an alias-only Project means the
// the id of the aliased attribute is the same as its index in the project list.
attr.exprId.id == index
case _ => false
Review Comment:
Interesting, the above didn't work I believe. Let me take a closer look by debugger. I didn't add the second case match at the beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1329072844
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The attribute id becomes the
// ordinal of this attribute in the child outputs. So an alias-only Project means the
// the id of the aliased attribute is the same as its index in the project list.
attr.exprId.id == index
case _ => false
Review Comment:
I'm totally confused
```
case (Alias(attr: AttributeReference, _), index) => ...
case (attr: AttributeReference, index) => ...
```
Why wouldn't the above work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1329298286
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The attribute id becomes the
// ordinal of this attribute in the child outputs. So an alias-only Project means the
// the id of the aliased attribute is the same as its index in the project list.
attr.exprId.id == index
case _ => false
Review Comment:
I am not sure how the existing behaves, but in my example I check the case where the expr.id is 1 but the index is 0.
<img width="762" alt="Screenshot 2023-09-18 at 2 19 49 PM" src="https://github.com/apache/spark/assets/1938382/e6850683-9557-4382-b203-be124c50606a">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #42971: [SPARK-43979][SQL][FOLLOWUP] Handle non alias-only project case
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1328287335
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The attribute id becomes the
// ordinal of this attribute in the child outputs. So an alias-only Project means the
// the id of the aliased attribute is the same as its index in the project list.
attr.exprId.id == index
case _ => false
Review Comment:
Actual it is not. Because `Alias` is not `Attribute`, we will miss the `Alias` case match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org