You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/21 12:25:33 UTC
[GitHub] [airflow] aboronnikov opened a new pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
aboronnikov opened a new pull request #12531:
URL: https://github.com/apache/airflow/pull/12531
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12531:
URL: https://github.com/apache/airflow/pull/12531#issuecomment-731572095
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12531:
URL: https://github.com/apache/airflow/pull/12531#discussion_r534126311
##########
File path: docs/concepts.rst
##########
@@ -220,6 +220,7 @@ execution_date
The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
This allows task instances to process data for the desired *logical* date & time.
+//TODO: rewrite this sentence to something understandable! The idea is too tricky!!! We are busy doing (did not ketch what we are doing). That is why the dag which supposed to be ran 3 monthes ago actually ran now?? Or what?? What all this words meen???
Review comment:
It would be great if you can point which part of this sentence you do not understand. I believe that we can together work out a better documentation to avoid such frustration in future. This however, requires you to explain us what is not understandable and why. Otherwise we face the risk that we will again write something that others cannot understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aboronnikov commented on a change in pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
Posted by GitBox <gi...@apache.org>.
aboronnikov commented on a change in pull request #12531:
URL: https://github.com/apache/airflow/pull/12531#discussion_r534093409
##########
File path: docs/concepts.rst
##########
@@ -220,6 +220,7 @@ execution_date
The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
This allows task instances to process data for the desired *logical* date & time.
+//TODO: rewrite this sentence to something understandable! The idea is too tricky!!! We are busy doing (did not ketch what we are doing). That is why the dag which supposed to be ran 3 monthes ago actually ran now?? Or what?? What all this words meen???
Review comment:
I would propose some better explanation in case if I understand all this stuff. But I did not understand it at all!!!!
I think that if somebody who understand this stuff will explain it in **other words** it would become much better! Present explanation is abracadabra!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12531:
URL: https://github.com/apache/airflow/pull/12531#issuecomment-786852481
We are going to massively re-write it via new scheduler interval AIP -- which would solve this issue for new users:
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-39+Richer+scheduler_interval
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aboronnikov commented on a change in pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
Posted by GitBox <gi...@apache.org>.
aboronnikov commented on a change in pull request #12531:
URL: https://github.com/apache/airflow/pull/12531#discussion_r534093409
##########
File path: docs/concepts.rst
##########
@@ -220,6 +220,7 @@ execution_date
The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
This allows task instances to process data for the desired *logical* date & time.
+//TODO: rewrite this sentence to something understandable! The idea is too tricky!!! We are busy doing (did not ketch what we are doing). That is why the dag which supposed to be ran 3 monthes ago actually ran now?? Or what?? What all this words meen???
Review comment:
I would propose some better explanation in case if I understand all this stuff. But I did not understand it at all!!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #12531:
URL: https://github.com/apache/airflow/pull/12531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12531:
URL: https://github.com/apache/airflow/pull/12531#discussion_r529297261
##########
File path: docs/concepts.rst
##########
@@ -220,6 +220,7 @@ execution_date
The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
This allows task instances to process data for the desired *logical* date & time.
+//TODO: rewrite this sentence to something understandable! The idea is too tricky!!! We are busy doing (did not ketch what we are doing). That is why the dag which supposed to be ran 3 monthes ago actually ran now?? Or what?? What all this words meen???
Review comment:
@aboronnikov would you like to propose more clear explanation? This is an open source project and we are happy when our users help us improve the code and documentation πͺ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12531:
URL: https://github.com/apache/airflow/pull/12531#discussion_r534127322
##########
File path: docs/concepts.rst
##########
@@ -220,6 +220,7 @@ execution_date
The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
This allows task instances to process data for the desired *logical* date & time.
+//TODO: rewrite this sentence to something understandable! The idea is too tricky!!! We are busy doing (did not ketch what we are doing). That is why the dag which supposed to be ran 3 monthes ago actually ran now?? Or what?? What all this words meen???
Review comment:
On the side note - there are better places to get you questions answered than question in comments in code:
https://github.com/apache/airflow/issues/new/choose
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12531: Rewrite sentence about execution_date, logical and actaul dag run time..
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12531:
URL: https://github.com/apache/airflow/pull/12531#discussion_r534126311
##########
File path: docs/concepts.rst
##########
@@ -220,6 +220,7 @@ execution_date
The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
This allows task instances to process data for the desired *logical* date & time.
+//TODO: rewrite this sentence to something understandable! The idea is too tricky!!! We are busy doing (did not ketch what we are doing). That is why the dag which supposed to be ran 3 monthes ago actually ran now?? Or what?? What all this words meen???
Review comment:
It would be great if you can point which part of this sentence you do not understand. I believe that we can together work out a better documentation to avoid such frustration in future. This however, requires you to explain us what is not understandable. Otherwise we face the risk that we will again write something that others cannot understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org