[GitHub] [incubator-tvm] t-vi edited a comment on pull request #6374: [Torch] Support logsumexp, clean up unnecessary infer_shape usage

[GitBox <gi...@apache.org>]

t-vi edited a comment on pull request #6374:
URL: https://github.com/apache/incubator-tvm/pull/6374#issuecomment-685453781


   Yeah, the thing that makes it ad hoc in my eyes is that
   - we don't have a view as which ops all lead to dynamic lists (e.g. append),
   - very likely we should have some criterion for recursion (e.g. handling slicing, which might be not that uncommon when you think of some "manual broadcasting"-style things).
   
   But again, I see the PR as a good improvement over the status quo and so I think its good to have. Thank you!
   (Also it's cool that you scan the hummingbird issues, I think this kind of thing really is key to people taking up TVM.)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org