[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1498: Warning message for invalid key in configuration file

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #1498:
URL: https://github.com/apache/incubator-kvrocks/pull/1498#discussion_r1232486511


##########
src/config/config.cc:
##########
@@ -659,6 +659,12 @@ Status Config::parseConfigFromPair(const std::pair<std::string, std::string> &in
     tokens[input.second] = input.first.substr(ns_str_size);
   }
   auto iter = fields_.find(field_key);
+
+  // Check if a configuration key is a valid key

Review Comment:
   Actually I wonder why not check `iter == fields_.end()` directly : )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org