You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2010/11/14 08:32:14 UTC
[jira] Created: (HADOOP-7034) Add TestPath tests to cover dot, dot
dot, and slash normalization
Add TestPath tests to cover dot, dot dot, and slash normalization
-----------------------------------------------------------------
Key: HADOOP-7034
URL: https://issues.apache.org/jira/browse/HADOOP-7034
Project: Hadoop Common
Issue Type: Test
Components: fs
Affects Versions: 0.22.0
Reporter: Eli Collins
Assignee: Eli Collins
Fix For: 0.22.0
Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7034) Add TestPath tests to cover dot, dot
dot, and slash normalization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7034:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Thanks Cos. I've committed this.
> Add TestPath tests to cover dot, dot dot, and slash normalization
> -----------------------------------------------------------------
>
> Key: HADOOP-7034
> URL: https://issues.apache.org/jira/browse/HADOOP-7034
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-7034-1.patch
>
>
> Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7034) Add TestPath tests to cover dot,
dot dot, and slash normalization
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931788#action_12931788 ]
Hadoop QA commented on HADOOP-7034:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12459548/hadoop-7034-1.patch
against trunk revision 1034480.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/102//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/102//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/102//console
This message is automatically generated.
> Add TestPath tests to cover dot, dot dot, and slash normalization
> -----------------------------------------------------------------
>
> Key: HADOOP-7034
> URL: https://issues.apache.org/jira/browse/HADOOP-7034
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-7034-1.patch
>
>
> Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7034) Add TestPath tests to cover dot,
dot dot, and slash normalization
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931985#action_12931985 ]
Hudson commented on HADOOP-7034:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #423 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/423/])
HADOOP-7034. Add TestPath tests to cover dot, dot dot, and slash normalization. Contributed by Eli Collins
> Add TestPath tests to cover dot, dot dot, and slash normalization
> -----------------------------------------------------------------
>
> Key: HADOOP-7034
> URL: https://issues.apache.org/jira/browse/HADOOP-7034
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-7034-1.patch
>
>
> Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7034) Add TestPath tests to cover dot, dot
dot, and slash normalization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7034:
--------------------------------
Attachment: hadoop-7034-1.patch
Patch attached. This is pretty trivial, just adds three asserts to TestPath#testNormalize. TestPath passes.
> Add TestPath tests to cover dot, dot dot, and slash normalization
> -----------------------------------------------------------------
>
> Key: HADOOP-7034
> URL: https://issues.apache.org/jira/browse/HADOOP-7034
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-7034-1.patch
>
>
> Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7034) Add TestPath tests to cover dot,
dot dot, and slash normalization
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932423#action_12932423 ]
Hudson commented on HADOOP-7034:
--------------------------------
Integrated in Hadoop-Common-trunk #514 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/514/])
> Add TestPath tests to cover dot, dot dot, and slash normalization
> -----------------------------------------------------------------
>
> Key: HADOOP-7034
> URL: https://issues.apache.org/jira/browse/HADOOP-7034
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-7034-1.patch
>
>
> Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7034) Add TestPath tests to cover dot, dot
dot, and slash normalization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7034:
--------------------------------
Status: Patch Available (was: Open)
> Add TestPath tests to cover dot, dot dot, and slash normalization
> -----------------------------------------------------------------
>
> Key: HADOOP-7034
> URL: https://issues.apache.org/jira/browse/HADOOP-7034
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-7034-1.patch
>
>
> Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7034) Add TestPath tests to cover dot,
dot dot, and slash normalization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931795#action_12931795 ]
Eli Collins commented on HADOOP-7034:
-------------------------------------
Not sure what the javadoc warning is about, I see 7 warnings with and w/o my change.
> Add TestPath tests to cover dot, dot dot, and slash normalization
> -----------------------------------------------------------------
>
> Key: HADOOP-7034
> URL: https://issues.apache.org/jira/browse/HADOOP-7034
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-7034-1.patch
>
>
> Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7034) Add TestPath tests to cover dot,
dot dot, and slash normalization
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931883#action_12931883 ]
Konstantin Boudnik commented on HADOOP-7034:
--------------------------------------------
+1 patch looks good.
> Add TestPath tests to cover dot, dot dot, and slash normalization
> -----------------------------------------------------------------
>
> Key: HADOOP-7034
> URL: https://issues.apache.org/jira/browse/HADOOP-7034
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hadoop-7034-1.patch
>
>
> Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.