[GitHub] [spark] lyy-pineapple commented on pull request #38171: [SPARK-9213] [SQL] Improve regular expression performance (via joni)

["lyy-pineapple (via GitHub)" <gi...@apache.org>]

lyy-pineapple commented on PR #38171:
URL: https://github.com/apache/spark/pull/38171#issuecomment-1489985307

   > `joni` seems to be used in Hbase client only instead of Hbase server or Hbase common.
   > 
   > * https://mvnrepository.com/artifact/org.apache.hbase/hbase-client/2.5.3
   > 
   > In addition, Trino is not using `jruby/joni`. It uses `airlift/joni`, a wrapper of `Joni`. https://github.com/trinodb/trino/blob/4cabec97ff62567d6bc8bcc40786eb0ac36b65ff/pom.xml#L910
   > 
   > ```
   >             <dependency>
   >                 <groupId>io.airlift</groupId>
   >                 <artifactId>joni</artifactId>
   >                 <version>2.1.5.3</version>
   >             </dependency>
   > ```
   > 
   > Given that, this seems to be used rarely. Do you think there is a reason?
   
   airlift/joni is fork form joni and fix some issue, joni also fix and other issue.  And joni is also dependented by other project (https://github.com/jruby/joni/network/dependents) .Joni meaning java pattern compatible with java matching rules. I optimized the unit test to more intuitively observe the correctness of the comparison between joni and java results.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org