Re: [PR] [incubator-kie-issues#1497] Using the getSerializableNodeInstances inside ProtobufProcessInstanceWriter [incubator-kie-kogito-runtimes]

["gitgabrio (via GitHub)" <gi...@apache.org>]

gitgabrio commented on PR #3707:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3707#issuecomment-2401496554

   > It would be great to have a unit test that actually tests the protobuf serialization changes.
   > 
   > Other than that, great work @gitgabrio
   
   I tried to write it (TBH, I still have it on my local) but the problem is that I'm ending up mocking everything, from NodeInstances to ProtobufProcessMarshallerWriteContext  to have the test working, and so it would not be a real test.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org