You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by schonfeld <gi...@git.apache.org> on 2015/09/17 20:45:47 UTC
[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE
GitHub user schonfeld opened a pull request:
https://github.com/apache/storm/pull/742
[STORM-1051] Fix for flushMessagse NPE
STORM-763 introduced a situation in which flushMessages could receive batch = null, in which case, an NPE is thrown because we weren't validating != null
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schonfeld/storm 0.10.x-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/742.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #742
----
commit bcc1cc6ce1b1455a68eae8f0b1d4ceafe93d8488
Author: Michael Schonfeld <mi...@schonfeld.org>
Date: 2015-09-17T15:57:07Z
fix npe issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/742#issuecomment-141480621
@schonfeld
Could you post a new PR which points to master, too?
Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE
Posted by schonfeld <gi...@git.apache.org>.
Github user schonfeld commented on the pull request:
https://github.com/apache/storm/pull/742#issuecomment-141500177
Closing in favor of PR #745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE
Posted by schonfeld <gi...@git.apache.org>.
Github user schonfeld closed the pull request at:
https://github.com/apache/storm/pull/742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---